DYMENSION: add memo fields to outbound ERC20 Collateral and Synthetic transfers, and Native transfers. by danwt · Pull Request #2 · dymensionxyz/hyperlane-monorepo

danwt · 2025-04-15T08:40:47Z

Have opened PR even though it's not finished (more tsts and couple small todos)

Please see the doc https://www.notion.so/dymension/ADR-Hyperlane-Integration-1dfa4a51f86a80e58db9cd966b7f289d for full writeup and link to test cases. Review set:

Deprecated: v1 DYMENSION: add memo fields to inbound ERC20 Collateral and Synthetic transfers hyperlane-cosmos#3
feat: Hyperlane integration + eibc transfer completion hooks dymension#1797
DYMENSION: add memo fields to outbound ERC20 Collateral and Synthetic transfers, and Native transfers. #2

… copy those

…llat on hub but get burn zero addr error

* backup the working dymension <-> ethereum test * add sol collateral memo, confirm all uts pass * add solana program build registration * pre add the registration for sol collateral memo * add changes to rust/sealevel/client/src/warp_route.rs untested * add sol client changes for collateral memo (untested) * try to fix and run build script, untested there is a build error for (non memo) collat about stack size * working on the dymension_test commands for sol * need to clean up env vars * more consolidation * in middle of sol test * going to have just one eth test and one sol test with dym * clean up the ethereum<->dymension test * rename dymension test -> ethereum test, delete backup, delete old eth<->eth test

* work on a script for eth collateral -> hub synthetic * cp * chore: forge init * forge install: forge-std v1.9.7 * try to make collateral erc20 work * deploy works, now need to test it * confirms that it works collateral -> synth on hub * bump foo_test * bump foo test readme

danwt · 2025-05-14T09:53:30Z

~~using dymensionxyz/hyperlane-cosmos#6~~

rust/sealevel/client/src/main.rs

keruch · 2025-05-15T16:01:11Z

rust/sealevel/client/src/main.rs

+                    let (escrow_account, _escrow_bump) = Pubkey::find_program_address(
+                        hyperlane_token_escrow_pda_seeds_memo!(),
+                        &query.program_id,
+                    );


accounts_to_query.push(escrow_account);

is missing

keruch · 2025-05-15T16:24:55Z

rust/sealevel/client/src/main.rs

+            let ixn = DymHtInstruction::TransferRemoteMemo(DymHtTransferRemoteMemo {
+                base: HtTransferRemote {
+                    destination_domain: xfer.destination_domain,
+                    recipient,
+                    amount_or_id: xfer.amount.into(),
+                },
+                memo: xfer.memo.as_bytes().to_vec(), // TODO: conversion OK?
+            });


the whole code for TokenSubCmd::TransferRemoteMemo is the same as for TokenSubCmd::TransferRemote except these lines, am I right? do you think it's worth spending time to dry it out? but I'm guessing it's fine anyway

yh
I didn't want to refactor too much to make it hard to sync with upstream
Probably worth spending some time on, but not now #5

keruch · 2025-05-15T17:16:30Z

rust/sealevel/programs/build-programs.sh

 # The paths to the programs
 CORE_PROGRAM_PATHS=("mailbox" "ism/multisig-ism-message-id" "validator-announce" "hyperlane-sealevel-igp")
-TOKEN_PROGRAM_PATHS=("hyperlane-sealevel-token" "hyperlane-sealevel-token-collateral" "hyperlane-sealevel-token-native")
+TOKEN_PROGRAM_PATHS=("hyperlane-sealevel-token" "hyperlane-sealevel-token-collateral",  "hyperlane-sealevel-token-collateral-memo", "hyperlane-sealevel-token-native",  "hyperlane-sealevel-token-native-memo","hyperlane-sealevel-token-memo")


hyperlane-sealevel-token-memo does not exist

nice catch!
btw https://www.notion.so/dymension/ADR-Hyperlane-Integration-1dfa4a51f86a80e58db9cd966b7f289d?pvs=4#1dfa4a51f86a80dfba58d1f1331bc4fe
it's a todo

keruch · 2025-05-15T17:26:33Z

typescript/sdk/src/token/EvmERC20WarpRouteReader.ts

+      [TokenType.collateralMemo]: {
+        factory: HypERC20CollateralMemo__factory,
+        method: 'wrappedToken',
+      },


TokenType.nativeMemo is missing?

is not erc20

keruch · 2025-05-15T17:28:12Z

typescript/sdk/src/token/Token.ts

        token: addressOrDenom,
      });
-    } else if (standard === TokenStandard.EvmHypSynthetic) {
+    } else if (standard === TokenStandard.EvmHypSynthetic || standard === TokenStandard.EvmHypSyntheticMemo ) {


do we need to do the same for EvmHypNativeMemo and EvmHypCollateralMemo?

probably a good idea 👍

dymension/dymension.readme.txt

Co-authored-by: keruch <53012408+keruch@users.noreply.github.com>

* add to readme * add copied synthetic token memo directory, same as non-memo * rust/sealevel/Cargo.toml * rust/sealevel/client/Cargo.toml * rust/sealevel/programs/build-programs.sh * should be all the changes for the token program itself * should be all the changes for the client package * fmt * build seems to work * start working on the sol test 2 (synthetic) * typo

danwt added 30 commits April 15, 2025 09:29

add dymension/

42db643

add erc20 memo

1ce28ec

fix dymension readme

d22c393

check point

e4c8ec6

please

961cd35

check point

4901ade

I need to add cli support for memos, but first, lets see if cast works?

7207308

ready to try again with adapted transferRemoteMemo call

ad7d237

check point

e3aceb4

pre delete erc20memo fac

29aebfd

confirm transferRemoteMemo is callable

b629a72

hack in the changes from original sealevel work 08b8712d99

94825a4

confirm solidity client changes build, but didnt retest

5b62307

time to proceed

b6eec62

adds a yarn project which is used for the scripting

bafe992

not sure its the right thing this cosmos script...

3112097

check point

49670d4

script not quite working but might as well add the eth side

059f110

check point

80f979a

make a manual script

ee13608

check point

e14ee7c

check point

b4c51cf

found some kyve testnet exsamples for relayer and chain registry, ill…

4773325

… copy those

check point

0e37fed

check point

4f88fb7

check point

e33947b

check point

febc275

check point

b745550

check point

59ed4a8

check point

42f5f8a

danwt added 7 commits May 7, 2025 16:58

progress

5f9af25

get as far as send back on synthetic memo hypERC20memo contract to co…

a77e709

…llat on hub but get burn zero addr error

finish confirmation for eth

9c42fa3

bumps

a82893b

fix

a2c44cc

danwt closed this May 14, 2025

danwt reopened this May 14, 2025

fix cmds

3b3f604

danwt closed this May 15, 2025

danwt reopened this May 15, 2025

keruch reviewed May 15, 2025

View reviewed changes

dymension/dymension.readme.txt Outdated Show resolved Hide resolved

keruch reviewed May 15, 2025

View reviewed changes

dymension/dymension.readme.txt Outdated Show resolved Hide resolved

danwt and others added 6 commits May 16, 2025 17:41

Update rust/sealevel/client/src/main.rs

a9f4ff5

Co-authored-by: keruch <53012408+keruch@users.noreply.github.com>

Update dymension/dymension.readme.txt

9a6b7da

Co-authored-by: keruch <53012408+keruch@users.noreply.github.com>

Update dymension/dymension.readme.txt

3f510d1

Co-authored-by: keruch <53012408+keruch@users.noreply.github.com>

remove unimpl

40137b2

add switch cases for nativememo, collateralmemo to token.ts

588b814

add missing line from sealevel client

58596c2

danwt requested a review from keruch May 16, 2025 17:00

danwt changed the title ~~DYMENSION: add memo fields to outbound ERC20 Collateral and Synthetic transfers, and Native transfers~~ DYMENSION: add memo fields to outbound ERC20 Collateral and Synthetic transfers, and Native transfers. (Solana synth is todo) May 16, 2025

keruch approved these changes May 20, 2025

View reviewed changes

danwt changed the title ~~DYMENSION: add memo fields to outbound ERC20 Collateral and Synthetic transfers, and Native transfers. (Solana synth is todo)~~ DYMENSION: add memo fields to outbound ERC20 Collateral and Synthetic transfers, and Native transfers. Jun 4, 2025

danwt merged commit 1915073 into main-dym Jun 4, 2025
33 of 53 checks passed

danwt deleted the danwt/main-dym-01 branch June 4, 2025 17:54

danwt mentioned this pull request Dec 18, 2025

refactor(kaspa-tools): improve error handling and API design #414

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DYMENSION: add memo fields to outbound ERC20 Collateral and Synthetic transfers, and Native transfers. #2

DYMENSION: add memo fields to outbound ERC20 Collateral and Synthetic transfers, and Native transfers. #2
danwt merged 93 commits intomain-dymfrom
danwt/main-dym-01

danwt commented Apr 15, 2025 •

edited

Loading

Uh oh!

danwt commented May 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

keruch May 15, 2025

Uh oh!

keruch May 15, 2025

Uh oh!

danwt May 16, 2025

Uh oh!

keruch May 15, 2025

Uh oh!

danwt May 16, 2025

Uh oh!

keruch May 15, 2025

Uh oh!

danwt May 16, 2025

Uh oh!

keruch May 15, 2025

Uh oh!

danwt May 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

danwt commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danwt commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

danwt commented Apr 15, 2025 •

edited

Loading

danwt commented May 14, 2025 •

edited

Loading