Skip to content

fix(solidity): apply CEI pattern to memo contracts #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danwt merged 1 commit into from
Nov 18, 2025
Merged

fix(solidity): apply CEI pattern to memo contracts #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion solidity/contracts/token/extensions/HypERC20CollateralMemo.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,13 @@ contract HypERC20CollateralMemo is HypERC20Collateral {
function _transferFromSender(
uint256 _amount
) internal virtual override returns (bytes memory) {
super._transferFromSender(_amount);
// Follow CEI pattern: read and clear _memo BEFORE external call
// to prevent reentrancy if wrappedToken has callbacks (ERC777, custom hooks)
bytes memory memo = _memo;
delete _memo;

super._transferFromSender(_amount);

emit IncludedMemo(memo);
return memo;
}
Expand Down
6 changes: 5 additions & 1 deletion solidity/contracts/token/extensions/HypERC20Memo.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,13 @@ contract HypERC20Memo is HypERC20 {
function _transferFromSender(
uint256 _amount
) internal virtual override returns (bytes memory) {
super._transferFromSender(_amount);
// Follow CEI pattern: read and clear _memo BEFORE burn
// to prevent reentrancy if child contracts override token hooks with external calls
bytes memory memo = _memo;
delete _memo;

super._transferFromSender(_amount);

emit IncludedMemo(memo);
return memo;
}
Expand Down
Loading