fix(kaspa): add serde aliases for flat-cased config keys#445
Merged
Conversation
The config library's CaseAdapter converts all JSON keys to flat case (e.g., escrowPub -> escrowpub), but the KaspaValidatorEscrow and KaspaValidatorIsm structs expect camelCase keys via serde rename_all. Adding serde aliases allows the structs to deserialize correctly when keys are flat-cased by the config library. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
escrowpubandismaddressto handle flat-cased config keysProblem
The config library's
CaseAdapterconverts all JSON keys to flat case (e.g.,escrowPub→escrowpub), but theKaspaValidatorEscrowandKaspaValidatorIsmstructs expect camelCase keys via#[serde(rename_all = "camelCase")]. This caused the error:Test plan
🤖 Generated with Claude Code