refactor(kaspa): remove max attempts from migration retry loops#451
Merged
refactor(kaspa): remove max attempts from migration retry loops#451
Conversation
Migration transactions have no payload (no withdrawals processed), but the trace function required a non-null payload. Treat null as empty — no message IDs to extract. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Same issue as relayer trace — validators also reject null payload with MissingTransactionPayload. Treat null as empty MessageIDs. Remove unused MissingTransactionPayload error variant. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Migration and hub sync now retry indefinitely instead of failing after 10 attempts. This is appropriate for an unattended process that must eventually succeed. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAX_ATTEMPTSconstant and simplifies control flowTest plan
🤖 Generated with Claude Code