Verify ISM signer for confirmation signatures#455
Merged
Conversation
danwt
force-pushed
the
danwt/claude/validate-ism-signatures
branch
from
439f850 to
58a4b60
Compare
Add signature verification for confirmation requests to match deposit behavior. Previously, confirmations did not validate that the signature came from the expected ISM address, allowing misconfigured validators to return signatures from wrong keys. Changes: - Add verify_ism_signer() helper for DRY signature validation - Update get_deposit_sigs() to use the shared helper - Add signature verification to get_confirmation_sigs() - Add SignableProgressIndication::new() constructor for external use - Always validate (ISM addresses are always required for sorting) Also includes minor formatting fixes from cargo fmt. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
danwt
force-pushed
the
danwt/claude/validate-ism-signatures
branch
from
58a4b60 to
a32b25b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify_ism_signer()helper function for DRY codeChanges
verify_ism_signer<T: Signable>()helper function that validates signatures against expected ISM addressesget_deposit_sigs()to use the shared helper (reduces code duplication)get_confirmation_sigs()using the same patternSignableProgressIndication::new()constructor for external usecargo fmtTest plan
cargo build -p dymension-kaspa🤖 Generated with Claude Code