Merge cors_fix delivery tracking into main-dym#461
Merged
Conversation
…ryDb for all destination chains, implement delivery status query, and update related database operations. Introduce new handler for checking message delivery status and streamline database interactions.
…ied expected format for message ID in comments and error messages, specifying hex string requirements and providing examples for better user guidance.
Merge Michael's delivery tracking and CORS features from the cors_fix branch into main-dym. Features added: - /delivered endpoint - check if a message was delivered by message_id - /dispatched endpoint - get message_id from transaction hash - CORS support for /reprocess_message route - DeliveryDb for tracking message delivery status across all chains This enables Tzachi's portal integration to query delivery status. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Change warn! to debug!/error! for appropriate log levels - Remove redundant log message prefixes (DELIVERY_API:, DISPATCHED_API:, etc.) - Set ADVANCED_LOG_META back to false - Remove unused message_syncs field from ServerState - Add SOLANA_SIGNATURE_BYTES constant for magic number 64 - Simplify delivery_db.rs implementation - Add comment documenting permissive CORS configuration Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
BLOCKING fixes: - Fix warn! to error! for failed delivery tx storage - Remove success/debug logging for delivery tx storage (follow log-after-action rule) - Remove leftover debug warn! with ALL CAPS in hyperlane_db.rs - Remove CORS from /reprocess_message (security: POST endpoints should not have permissive CORS) - Remove unused origin_db_delivery field from MessageContext MAJOR fixes: - Remove duplicate tx->message_id reverse mapping from delivery_db.rs (origin-side mapping via HyperlaneDb is sufficient for /dispatched endpoint) - Remove logging from low-level DB methods (let callers decide) Simplifies delivery_db.rs to only store message_id -> delivery_tx mapping, which is what the /delivered endpoint actually uses. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Downgrade error! to debug! for best-effort delivery tx storage - Fix idempotency: store_message_with_dispatch_tx now returns actual store_message result and only stores dispatch tx mapping for new messages - Remove unused warn import from hyperlane_db.rs - Fix spurious blank lines in hyperlane_db.rs and contract_sync/mod.rs Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merges Michael's delivery tracking and CORS features from the
cors_fixbranch intomain-dym.Features added:
/deliveredendpoint - check if a message was delivered by message_id and domain_id/dispatchedendpoint - get message_id from transaction hash (reverse lookup)/reprocess_messagerouteDeliveryDbtrait for tracking delivery tx hashesHow delivery tracking works
When the relayer successfully delivers a message to a destination chain, it stores:
message_id -> delivery_tx_hashmapping (for/deliveredqueries)dispatch_tx_hash -> message_idmapping (for/dispatchedqueries)The data is stored in RocksDB using the
DeliveryDbtrait implementation.API Endpoints
GET /delivered
message_id(hex),domain_id(destination domain){ delivered: bool, tx_hash: string | null }GET /dispatched
tx_hash(hex or base58 for Solana),domain_id(origin domain){ message_id: string, destination_domain_id: u32 }CORS Configuration
CORS is configured with
allow_origin(Any)for the delivery endpoints and/reprocess_message. This is intentional as these are public read-only APIs. The permissive configuration allows frontend applications (like the portal) to query delivery status directly.Test plan
/deliveredendpoint returns correct delivery status/dispatchedendpoint returns message_id from tx hash🤖 Generated with Claude Code