Skip to content

fix: ibc stargate filter + ASA-2025-004 ibc 6 fix#265

Open
srene wants to merge 4 commits intomainfrom
srene/stargate_ibcfilter
Open

fix: ibc stargate filter + ASA-2025-004 ibc 6 fix#265
srene wants to merge 4 commits intomainfrom
srene/stargate_ibcfilter

Conversation

@srene
Copy link

@srene srene commented Jan 28, 2026

Description


Closes #266,#267

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@srene srene self-assigned this Jan 28, 2026
@srene srene requested a review from a team as a code owner January 28, 2026 10:51
@srene srene marked this pull request as draft January 28, 2026 10:51
@srene srene linked an issue Jan 28, 2026 that may be closed by this pull request
@srene srene changed the title fix: ibc stargate filter fix: ibc stargate filter + ASA-2025-004 ibc 6 fix Jan 29, 2026
@srene srene marked this pull request as ready for review January 29, 2026 13:31
@srene srene marked this pull request as draft January 29, 2026 13:31
@srene srene linked an issue Jan 29, 2026 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.14%. Comparing base (95ef0d2) to head (a7a21e7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/stargate_filter.go 58.82% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   23.05%   23.14%   +0.09%     
==========================================
  Files         106      107       +1     
  Lines       14785    14827      +42     
==========================================
+ Hits         3408     3432      +24     
- Misses      11035    11051      +16     
- Partials      342      344       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@srene srene marked this pull request as ready for review January 29, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use ibc dym fork wasm contracts can skip ibc ante handler

1 participant