fix: fallback to latest celestia block when state height is below tail#1431
Open
anhductn2001 wants to merge 1 commit intomainfrom
Open
fix: fallback to latest celestia block when state height is below tail#1431anhductn2001 wants to merge 1 commit intomainfrom
anhductn2001 wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
|
Do you think this fallback to the latest height is okay? @srene |
artemijspavlovs
requested changes
Dec 15, 2025
Collaborator
artemijspavlovs
left a comment
There was a problem hiding this comment.
it's not the latest that should be retrieved,
the way it should work is - retrieve first state update from hub, extract the da height that it was submitted on ( there already are utility functions/methods for that in roller ) and use that height.
if the da client needs even earlier data, for whatever reason - roller, most likely should extract the required height, update da light client config and restart the da client so it syncs the necessary heights
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Standards
Close #1423
Opening a pull request should be able to meet the following requirements
For Author:
godoccommentsFor Reviewer:
After reviewer approval: