-
Notifications
You must be signed in to change notification settings - Fork 14
Mid-Sized Rewrite of APIs + Devcontainer + Docs Fixes #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ludgerpaehler
wants to merge
76
commits into
main
Choose a base branch
from
lp/bug-hunting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upon the non-existence of Firedrake.
This was referenced Mar 30, 2025
…the foreign function interface.
… lp/bug-hunting Merge quick changes to the remote into the working branch.
❌ Deploy Preview for hydrogym failed.
|
Collaborator
Author
|
Presently at 677 mypy errors. To be brought down to 0 for the merge. |
…d like any other package from PyPi.
❌ Deploy Preview for hydrogym failed.
|
Collaborator
Author
|
Mypy to be replaced in favor of PyreFly for a better developer experience, and better IDE integration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps version to 0.1.3.0 in light of the changes below:
pyproject.tomlrllibi.e.pip install "hydrogym[rllib]"installs the required additional dependencies now to run
rllibwith HydroGym out of the box.pip install -e .or
pip install ".[rllib]"pip.tryconstruct to gracefully return an error to the user in case Firedrake is not found in the current environment, but needed by HydroGym. To give an example of the construct:colabfolder, in which they can still be launched with Jupyter, but going beyond the previous state, can be auto-launched into Google Colab using the groundwork laid by FEM-on-Colab.