Skip to content

Conversation

@yb6599
Copy link
Collaborator

@yb6599 yb6599 commented May 8, 2025

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2025

Codecov Report

❌ Patch coverage is 96.05263% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.94%. Comparing base (f9022b4) to head (1727293).
⚠️ Report is 37 commits behind head on master.

Files with missing lines Patch % Lines
pysensors/reconstruction/_sspor.py 95.00% 5 Missing ⚠️
pysensors/optimizers/_tpgr.py 98.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   95.95%   95.94%   -0.02%     
==========================================
  Files          21       22       +1     
  Lines        1089     1233     +144     
==========================================
+ Hits         1045     1183     +138     
- Misses         44       50       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yb6599 yb6599 changed the title TPGR Optimizer, Maximal Likelihood Reconstructor and Uncertainty Quantification TPGR Optimizer, Regularized Reconstruction and Uncertainty Quantification Jun 4, 2025
@yb6599
Copy link
Collaborator Author

yb6599 commented Jun 4, 2025

@niharika2999 The tests fail because there's an issue with the pysensors_overview notebook. I think it's a good idea to update all the notebooks here.

@yb6599 yb6599 force-pushed the uq-implementation branch from ca0456d to 8ea18ca Compare June 4, 2025 06:14
@yb6599 yb6599 requested a review from niharika2999 June 4, 2025 06:20

def get_sensors(self):
check_is_fitted(self, "sensors_")
return self.sensors_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge

)
J_full = np.full(G.shape[0], np.nan)
J_full[mask] = J
return J_full
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge

@kmanohar kmanohar merged commit cc366f1 into dynamicslab:master Jun 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants