Skip to content

Make FROLS.history_ as a list#619

Merged
Jacob-Stevens-Haas merged 3 commits intomasterfrom
issue-377
Jul 29, 2025
Merged

Make FROLS.history_ as a list#619
Jacob-Stevens-Haas merged 3 commits intomasterfrom
issue-377

Conversation

@yb6599
Copy link
Copy Markdown
Collaborator

@yb6599 yb6599 commented May 6, 2025

Fixes 377

@yb6599 yb6599 changed the title Fix for Issue 377 Make FROLS.history_ as a list May 6, 2025
@yb6599 yb6599 linked an issue May 6, 2025 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2025

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.20%. Comparing base (069afc9) to head (f75b6d7).
⚠️ Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
pysindy/optimizers/frols.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #619      +/-   ##
==========================================
- Coverage   95.29%   95.20%   -0.09%     
==========================================
  Files          39       39              
  Lines        4120     4152      +32     
==========================================
+ Hits         3926     3953      +27     
- Misses        194      199       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread pysindy/optimizers/frols.py Outdated
Comment on lines +175 to +176
# History of selected functions as a list of [output x coefficients]
# with a length of number of iterations
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comment

@Jacob-Stevens-Haas Jacob-Stevens-Haas merged commit 1e5fb9e into master Jul 29, 2025
6 of 8 checks passed
@Jacob-Stevens-Haas Jacob-Stevens-Haas deleted the issue-377 branch July 29, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] FROLS makes .history_ an array, not a list.

2 participants