Conversation
aaf66b6 to
58a1801
Compare
58a1801 to
cba1d72
Compare
bf3848a to
faf2ec6
Compare
4de6e0e to
d639a73
Compare
Implement comprehensive priority transition tracking and filtering for tasks: - Add `--priority` flag with advanced filtering patterns - Introduce `--show-history` for detailed transition tracking - Support priority change direction (raised/lowered) - Enhance documentation with priority filtering examples - Add `--show-metadata` for filter debugging
d639a73 to
be07e87
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds comprehensive priority-based filtering for Maniphest tasks and restructures the output format to provide clearer separation between current state, history, and filter metadata.
Key Features
🎯 Priority Filtering
Filter tasks based on priority changes over time, complementing the existing column transition filtering.
Supported patterns:
from:PRIORITY[:direction]- Task changed from a priority (optionally with raised/lowered direction)to:PRIORITY- Task changed to a priorityin:PRIORITY- Task is currently at a prioritybeen:PRIORITY- Task was at a priority at any point in historynever:PRIORITY- Task was never at a priorityraised- Task had any priority increaselowered- Task had any priority decreaseExamples:
📊 Restructured Output Format
The task output is now organized into three clear sections:
1. Task - Current state snapshot
2. History - Transition timeline (only shown with
--show-history)3. Metadata - Filter match information (only shown with
--show-metadata)🔍 Filter Debugging with
--show-metadataNew flag to help debug complex filter combinations by showing exactly which boards and priorities matched your filters.
This shows:
--columnfilter--priorityfilter🔄 Explicit History Display
History is now only shown when explicitly requested with
--show-history, not auto-enabled by filters. This improves performance for quick filtering operations.Technical Changes
New Files
phabfive/priority_transitions.py- Priority filtering logic with pattern matchingtests/test_priority_transitions.py- Comprehensive test suite (51 tests)Modified Files
phabfive/cli.py- Added--priority,--show-metadataflags; removed deprecated--show-transitionsphabfive/maniphest.py- Restructured output, priority filtering integration, alphabetical board sortingdocs/maniphest-cli.md- Comprehensive documentation for new featurestests/test_maniphest.py- Updated for new method signaturesBreaking Changes
--show-transitionsflag (use--show-historyinstead)--show-historyUse Cases
Track Priority Escalations
Audit Workflow Compliance
Debug Complex Filters
Sprint Analysis