Skip to content

🔧 Improve container runtime checks in Makefile #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Timpan4 merged 1 commit into from
Nov 12, 2025
Merged

🔧 Improve container runtime checks in Makefile #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
.PHONY: help clean cleanpy cleanall cleantox cleanvenv test install phorge-down phorge-up phorge-logs phorge-shell phabfive-build phabfive-run phabfive-run-dev docs

# Detect container runtime (prefer podman)
CONTAINER_RUNTIME := $(shell command -v podman 2> /dev/null)
ifndef CONTAINER_RUNTIME
CONTAINER_RUNTIME := $(shell command -v docker 2> /dev/null)
endif
ifndef CONTAINER_RUNTIME
$(error Neither podman nor docker found. Please install one of them.)
endif
CONTAINER_RUNTIME = $(or \
$(shell command -v podman 2>/dev/null), \
$(shell command -v docker 2>/dev/null) \
)

COMPOSE_FILE := compose-phorge.yml

Expand Down Expand Up @@ -70,28 +67,36 @@ sdist: clean ## make a source distribution
bdist: clean ## build a wheel distribution
uv build --wheel

check-runtime: ## Checks runtime and exits if not found
@echo "Checking runtime..."
@if [ -z "$(CONTAINER_RUNTIME)" ]; then \
echo "Error: Neither podman nor docker found."; \
exit 1; \
fi
@$(CONTAINER_RUNTIME) --version

##@ Phorge Testing

phorge-down: ## stop and remove phorge containers
phorge-down: check-runtime ## stop and remove phorge containers
$(CONTAINER_RUNTIME) compose -f $(COMPOSE_FILE) down

phorge-up: ## start phorge (mariadb detached, phorge in foreground)
phorge-up: check-runtime ## start phorge (mariadb detached, phorge in foreground)
@echo "Starting mariadb in background..."
@$(CONTAINER_RUNTIME) compose -f $(COMPOSE_FILE) up -d mariadb
@echo "Waiting for mariadb to be ready..."
@sleep 3
@echo "Starting phorge in foreground (logs will be visible)..."
$(CONTAINER_RUNTIME) compose -f $(COMPOSE_FILE) up --build phorge

phorge-logs: ## view logs from phorge containers
phorge-logs: check-runtime ## view logs from phorge containers
$(CONTAINER_RUNTIME) compose -f $(COMPOSE_FILE) logs -f

phorge-shell: ## open shell in phorge container
phorge-shell: check-runtime ## open shell in phorge container
$(CONTAINER_RUNTIME) compose -f $(COMPOSE_FILE) exec phorge /bin/bash

##@ Docker

phabfive-build: ## build phabfive docker image
phabfive-build: check-runtime ## build phabfive docker image
$(CONTAINER_RUNTIME) build -f Dockerfile -t phabfive .

phabfive-run: phabfive-build ## run phabfive in docker container with ARGS="your args here"
Expand Down