Fix/callback interaval balancing #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow specifing callback's offset in schedule method
DtDamianGrzes
force-pushed
the
fix/callback-interaval-balancing
branch
3 times, most recently
from
e3e8999 to
6ec9093
Compare
DtDamianGrzes
force-pushed
the
fix/callback-interaval-balancing
branch
from
6ec9093 to
9e2d369
Compare
Co-authored-by: Copilot <[email protected]>
afurche
approved these changes
Dec 15, 2025
dlopes7
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#133 broke random distribution of callbacks across heartbeat interval. Compared to
start_timestamp,start_timestamp_monotonicis not updated after the first call, which leads to the situation where the first call is executed with random offset, but the following ones are executed in full intervals measuring from callback's creation. Eg. 15 sec -> 60 sec -> 120 sec -> etcAnother possible fix would be to update
start_timestamp_monotonicwith first call, but that causes some data races, so I chose to use the offset in each calculation. Current expected behavior would be eg. 15 sec -> 75 sec -> 135 sec -> etc.I also added possibility to define offset for the specific callback, which is used in Dynatrace's end to end tests.