Dev/skruk/enh dynamic tables grant#65
Merged
sebastiankruk merged 11 commits intodynatrace-oss:release/0.9.4from Mar 9, 2026
Merged
Dev/skruk/enh dynamic tables grant#65sebastiankruk merged 11 commits intodynatrace-oss:release/0.9.4from
sebastiankruk merged 11 commits intodynatrace-oss:release/0.9.4from
Conversation
…logic for Dynamic Tables - Add table-level grant pass to `032_p_grant_monitor_dynamic_tables.sql` documentation - Update CHANGELOG and DEVLOG to clarify three-pass approach (database, schema, table) - Update grant matrix in config.md and PLUGINS.md to include table-level pattern example - Add DYNAMIC TABLE entry to bom.yml for exact table name grants - Fix PLUGINS.md Event Log description to clarify cross-tenant monitoring behavior
sebastiankruk
added
enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Dynamic Tables privilege grants to match the configured include pattern granularity (database vs schema vs specific table) and adjusts docs/tests accordingly.
Changes:
- Add test logic to ignore deploy-time
--%OPTIONblocks when scanning for admin-role usage. - Update
P_GRANT_MONITOR_DYNAMIC_TABLES()to issue DATABASE/SCHEMA/TABLE-level grants based on include patterns. - Refresh plugin docs/BOM/changelog entries to describe the new grant granularity.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| test/core/test_admin_role_usage.py | Skips --%OPTION blocks during file scanning to avoid false positives. |
| src/dtagent/plugins/dynamic_tables.sql/admin/032_p_grant_monitor_dynamic_tables.sql | Implements multi-pass grant logic for database/schema/table granularity. |
| src/dtagent/plugins/dynamic_tables.config/config.md | Documents how include patterns map to grant granularity. |
| src/dtagent/plugins/dynamic_tables.config/bom.yml | Updates referenced objects to reflect database/schema/table grant variants for dynamic tables. |
| docs/PLUGINS.md | Updates Dynamic Tables docs and adds Event Log cross-tenant/database filtering documentation. |
| docs/DEVLOG.md | Adds technical notes describing the dynamic tables grant granularity fix. |
| docs/CHANGELOG.md | Adds changelog entry for the dynamic tables grant behavior change. |
| .github/copilot-instructions.md | Updates internal contributor instructions for docs build script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
src/dtagent/plugins/dynamic_tables.sql/admin/032_p_grant_monitor_dynamic_tables.sql
Outdated
Show resolved
Hide resolved
src/dtagent/plugins/dynamic_tables.sql/admin/032_p_grant_monitor_dynamic_tables.sql
Outdated
Show resolved
Hide resolved
src/dtagent/plugins/dynamic_tables.sql/admin/032_p_grant_monitor_dynamic_tables.sql
Outdated
Show resolved
Hide resolved
src/dtagent/plugins/dynamic_tables.sql/admin/032_p_grant_monitor_dynamic_tables.sql
Outdated
Show resolved
Hide resolved
src/dtagent/plugins/dynamic_tables.sql/admin/032_p_grant_monitor_dynamic_tables.sql
Outdated
Show resolved
Hide resolved
src/dtagent/plugins/dynamic_tables.sql/admin/032_p_grant_monitor_dynamic_tables.sql
Outdated
Show resolved
Hide resolved
micjaki
approved these changes
Mar 6, 2026
Signed-off-by: Sebastian Kruk <1426486+sebastiankruk@users.noreply.github.com>
dorian-krefft-dt
approved these changes
Mar 9, 2026
…ncies - Add new `test-bash-slow` job that runs only on main, devel, and release branches - Configure slow tests to run with `--run-slow` flag for build/package/compile operations - Install flake8, black, and pylint dependencies in both bash test jobs
…output formatting - Create build/30_plugins and build/09_upgrade directories in test_compile.bats setup to prevent failures in fresh CI checkouts - Add stdout output to bash test failure messages for better debugging alongside existing stderr output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.