Remove Temporal runtime and workflow surface; route notifications via OTel#52
Merged
Remove Temporal runtime and workflow surface; route notifications via OTel#52
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request removes the Temporal workflow runtime and replaces workflow-driven flow dispatch with an in-process flow runtime that routes notifications via OTel. The change affects backend workflow APIs, frontend Temporal UI integration, configuration settings, and documentation.
Changes:
- Removed Temporal workflow APIs (
/api/workflows,/api/sessions/:id/workflow/resume,/api/sessions/:id/workflow/history) and status fields - Replaced workflow-driven flow dispatch with in-process flow runtime using OTel-backed notifications
- Added CI guard script to prevent Temporal reintroduction and frontend dependency
orga
Reviewed changes
Copilot reviewed 114 out of 116 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/check-no-temporal.sh | New CI guard to prevent Temporal patterns from being reintroduced |
| internal/terminal/session*.go | Removed workflow methods and fields from Session type |
| internal/terminal/session_factory.go | Added NotificationSink for direct event emission |
| internal/terminal/manager.go | Removed Temporal client/worker integration |
| internal/api/workflow_routes_test.go | New test verifying removed routes return 404 |
| internal/api/rest_*.go | Removed workflow endpoints and Temporal UI URL from status |
| internal/api/notifications_sse_handler.go | Updated to read from OTel LogHub instead of notification bus |
| internal/flow/service.go | Replaced Temporal client with Dispatcher interface |
| internal/flow/runtime/dispatcher*.go | New in-process dispatcher for flow activities |
| internal/notify/*.go | New notification sink abstraction for OTel integration |
| internal/config/settings.go | Removed Temporal configuration settings |
| cmd/gestalt/temporal.go | Removed Temporal dev server lifecycle management |
| cmd/gestalt/server_command.go | Removed Temporal client/worker startup and shutdown phases |
| frontend/src/lib/apiClient.js | Removed workflow API methods |
| frontend/src/components/Terminal.svelte | Removed Temporal UI button and added connection failure callback |
| frontend/src/views/*.svelte | Removed Temporal context loading and UI elements |
| frontend/package.json | Added orga dependency for org-mode parsing |
| docs/**/*.md | Updated documentation to reflect workflow removal |
| config/gestalt.toml | Removed Temporal settings section |
| .github/workflows/tests.yml | Added Temporal guard check to CI |
Files not reviewed (1)
- frontend/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 1.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key changes