Skip to content

Conversation

@omdxp
Copy link
Member

@omdxp omdxp commented Dec 20, 2024

  • Instantiating the MeiliSearch client with the necessary indexing during the SearchService instantiation.
  • Add index service method to save new entries with their specific indexes.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (changes that require a fresh clone of the repo)
  • I'm not sure

@omdxp omdxp self-assigned this Dec 20, 2024
@github-actions github-actions bot added feature Feature api API related changes ( api folder ) labels Dec 20, 2024
@omdxp omdxp marked this pull request as ready for review December 20, 2024 12:48
@omdxp omdxp requested a review from ZibanPirate December 20, 2024 12:48
@omdxp omdxp requested a review from ZibanPirate December 20, 2024 13:27
@ZibanPirate ZibanPirate added this to the Search functionality milestone Dec 20, 2024
@omdxp omdxp requested a review from ZibanPirate December 20, 2024 14:49
@omdxp omdxp requested a review from ZibanPirate December 20, 2024 14:59
Copy link
Member

@ZibanPirate ZibanPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more thing we forgot to do in #617 , otherwise API server won't bootstrap on cloud:

  meilisearch:
    image: getmeili/meilisearch:latest
    ports:
      - "7700:7700"
    volumes:
      - /home/ubuntu/app-data/api/meilisearch_db:/data.ms
    environment:
      MEILI_NO_ANALYTICS: true
      MEILI_MASTER_KEY: "default"

Copy link
Member

@ZibanPirate ZibanPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

annnnd one last thing (i promise)

in both docker-compose files, the volume is not correct, should change data.ms to meili_data

@omdxp omdxp requested a review from ZibanPirate December 20, 2024 15:46
@omdxp omdxp merged commit 1b9d79e into main Dec 20, 2024
20 checks passed
@omdxp omdxp deleted the using-meilisearch-client branch December 20, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api API related changes ( api folder ) feature Feature

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

3 participants