Global Search #624
Merged
Global Search #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
omdxp
commented
Dec 24, 2024
omdxp
commented
- Add full flow for searching.
- Make shared component cards for search results and corresponding pages.
- Add global search input component.
- Bug fix
- New feature
- Other
…better data retrieval
github-actions
bot
added
feature
…roved clarity and structure
…ype safety and clarity
…ges for better user experience
ZibanPirate
requested changes
Dec 24, 2024
…ion cards for consistency
…arch and TopBar components
…proved layout consistency
…rt paths for consistency
…, contributors, and contributions
ZibanPirate
reviewed
Dec 24, 2024
Member
ZibanPirate
left a comment
ZibanPirate
left a comment
There was a problem hiding this comment.
left a few mostly-optional comments, apart from the bug comment (we should note that down)
Member
There was a problem hiding this comment.
maybe it makes sense for this to live inside web/src/components/search.tsx
…e state with an empty array
ZibanPirate
approved these changes
Dec 24, 2024
Member
ZibanPirate
left a comment
ZibanPirate
left a comment
There was a problem hiding this comment.
🚀🔎 pretty fast on staging already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.