fix 645: set tags in resourceNetboxTenantRead#646
Open
sempervictus wants to merge 1 commit intoe-breuninger:masterfrom
Open
fix 645: set tags in resourceNetboxTenantRead#646sempervictus wants to merge 1 commit intoe-breuninger:masterfrom
sempervictus wants to merge 1 commit intoe-breuninger:masterfrom
Conversation
Author
|
These tests are ... "illogical": is exactly what should be happening because the provider ignored the need to populate its own fields and really the tests should always fail on any data field being |
dbeeeb5 to
51b1204
Compare
Author
|
its the same failure: === NAME TestAccNetboxTenant_tags
resource_netbox_tenant_test.go:81: Step 1/3 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
stdout
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# netbox_tenant.test_tags will be updated in-place
~ resource "netbox_tenant" "test_tags" {
id = "34"
name = "test-tenant_tags-3q7i1rndso"
~ tags = [
+ "test-tenant_tags-3q7i1rndsoa",
]
# (2 unchanged attributes hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
--- PASS: TestAccNetboxToken_basic (2.43s) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address #645