Skip to content

Conversation

@mishushakov
Copy link
Member

@mishushakov mishushakov commented Oct 17, 2025

I haven't modified the source for compatibility reasons, so it can still be released as a Docker image


Note

Switches the base template to JS SDK-driven builds (dev/prod), adds package.json and template config, updates Dockerfile user creation, and removes e2b.toml.

  • Templates/Base:
    • Build: Add build.dev.ts and build.prod.ts using Template.build with defaultBuildLogger() and alias handling.
    • Template Config: Add template.ts exporting alias: 'base' and Template().fromDockerfile('e2b.Dockerfile'); add package.json with build:dev and build:prod scripts.
    • Dockerfile: Change Node user creation to system account (groupadd -r/useradd -r).
    • Cleanup: Remove e2b.toml.

Written by Cursor Bugbot for commit 6f55a51. This will update automatically on new commits. Configure here.

@linear
Copy link

linear bot commented Oct 17, 2025

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2025

⚠️ No Changeset found

Latest commit: 6f55a51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR


RUN groupadd --gid 1000 node \
&& useradd --uid 1000 --gid node --shell /bin/bash --create-home node
RUN groupadd -r node && useradd -r -g node -s /bin/bash -m node
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was edited because I was getting:

groupadd: GID '1000' already exists

# const sandbox = await Sandbox.create('base')

team_id = "460355b3-4f64-48f9-9a16-4442817f79f5"
memory_mb = 512
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the memory setup should be explicitly set as the defaults can change

import { defaultBuildLogger, Template } from '../../packages/js-sdk/src'
import { template, alias } from './template'

await Template.build(template, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the base template is already built in the Infra repo. I think we might want to have here only the Docker image build, no template at all

@dobrac dobrac self-assigned this Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants