Skip to content

during sdk release check not just source code but dep files #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

during sdk release check not just source code but dep files #72

merged 1 commit into from
Mar 26, 2025

Conversation

@sitole
Copy link
Member

@sitole sitole commented Mar 25, 2025 •
edited
Loading

fixing issue with skipped release when there are just deps updated (#71)

@sitole sitole added the improvement Improvement for current functionality label Mar 25, 2025
@sitole sitole requested review from jakubno and mishushakov March 25, 2025 15:59
@sitole sitole self-assigned this Mar 25, 2025
jakubno
jakubno requested changes Mar 25, 2025
View reviewed changes
Copy link
Member

@jakubno jakubno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's an issue with package after update, because the package.json, pyproject.toml with the new versions are commited after the release, so there will be always a change for last released package(s)

@sitole sitole marked this pull request as draft March 25, 2025 17:57
@sitole sitole force-pushed the fixed-release-process-for-deps-changes branch from bb9b8f1 to b7da3e1 Compare March 25, 2025 17:58
@ValentaTomas ValentaTomas removed the request for review from 0div March 25, 2025 18:29
@sitole sitole force-pushed the fixed-release-process-for-deps-changes branch from 3c03f19 to 4b6d968 Compare March 26, 2025 11:24
@sitole
Copy link
Member Author

sitole commented Mar 26, 2025

CI Run with demo action that is using this new script to decide if package should be release.
Currently correctly outputs for JS and Python SDKs.

@sitole sitole requested a review from jakubno March 26, 2025 11:25
@sitole sitole marked this pull request as ready for review March 26, 2025 11:25
@jakubno jakubno merged commit 870e4c6 into main Mar 26, 2025
1 check passed
@jakubno jakubno deleted the fixed-release-process-for-deps-changes branch March 26, 2025 11:39
This was referenced Mar 27, 2025
Merged
Merged
jakubno pushed a commit to e2b-dev/E2B that referenced this pull request Mar 27, 2025
@sitole
Script for per-package check if release is needed (#641)
9f7957d 
Inspired by original change in code-interpreter release process
e2b-dev/code-interpreter#72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakubno jakubno jakubno approved these changes

@mishushakov mishushakov Awaiting requested review from mishushakov mishushakov is a code owner

@ValentaTomas ValentaTomas Awaiting requested review from ValentaTomas ValentaTomas is a code owner

Assignees

@sitole sitole

Labels

improvement Improvement for current functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sitole @jakubno