HotFix: Simplify teamIdOrSlug schema validation #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jakubno
approved these changes
Nov 11, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
|
|
||
| if (z.uuid().safeParse(segment).success) { | ||
| // FIXME: should check for the case if this is a slug which has the same format as a uuid, before returning |
There was a problem hiding this comment.
Bug: UUID Format Confusion Leads to Authorization Bypass
When segment is a valid UUID format, the function returns it directly without verifying it exists as a team ID in the database. Since the schema now accepts any string as a slug, a team could have a slug that's UUID-formatted. This causes the function to incorrectly treat the slug as a team ID, potentially returning a non-existent team ID or bypassing authorization checks.
Member
Author
There was a problem hiding this comment.
it won't bypass authorization. it would result in potentially invalid access denials to the dashboard
jakubno
approved these changes
Nov 11, 2025
ben-fornefeld
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous TeamIdOrSlugSchema regex did not match the possible slugs in the database 100% of the time.
Note
Loosens teamIdOrSlug validation, verifies UUIDs against DB to avoid slug/ID collisions, and adds structured warning logs in dashboard and team middleware.
TeamIdOrSlugSchemanow accepts anystring(removed slug regex) alongsideuuid.getTeamIdFromSegmentverifies UUIDs againstteamstable and ensures they aren’t treated as IDs when they match a slug; retains slug lookup and usesserver-only.app/dashboard/[teamIdOrSlug]/layout.tsxwhen team cannot be resolved (with serialized error).withTeamIdResolutionmiddleware for invalidteamIdOrSlugand unauthorized access.Written by Cursor Bugbot for commit bbb083f. This will update automatically on new commits. Configure here.