Refactor: Templates api layer to trpc #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dobrac
approved these changes
Nov 18, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| ...(templatesData?.templates ?? []), | ||
| ], | ||
| [templatesData, defaultTemplatesData] | ||
| ) |
There was a problem hiding this comment.
Bug: Template display order reversed
The templates array now places default templates before team templates, reversing the original order where team templates appeared first. Since there's no default sorting applied, this changes the display order in the UI. The original code had team templates first, then default templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Move Templates from server actions to tRPC (queries/mutations) with React Query, add prefetch/hydration, and refine telemetry and prefetch utilities.
templatesRouterwithgetTemplates,getDefaultTemplatesCached,updateTemplate,deleteTemplate; register intrpcAppRouter.TemplatesTableand cells to useuseTRPC+useSuspenseQuery/useMutationwith optimistic updates and error toasts; remove server actions and old fetching modules.HydrateClient+SuspensewithLoadingLayoutand client-sideErrorBoundaryhandling.prefetch(...)and keepprefetchAsync(...); update Sandboxes/Templates pages to use non-awaitedprefetch.causeexists); tweak success log message.server/templates/*, templates routeloading.tsx).Written by Cursor Bugbot for commit bb321c8. This will update automatically on new commits. Configure here.