Improve: Enforce 15MB max file size limit before downloading/viewing sandbox inspect files #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-fornefeld
added
bug
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Co-authored-by: Jakub Novák <[email protected]>
ben-fornefeld
deleted the
investigate-large-readable-file-crashes-sandbox-inspect-eng-3333
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds a 15MB max preview limit with pre-read size checks, introduces explicit unreadable states (file_type, too_large), and updates viewer messaging accordingly.
MAX_VIEWABLE_FILE_SIZE_BYTES(15MB) and pre-checks file size viafiles.getInfobefore reading. Oversized files setunreadablewithreason: 'too_large'and includesize.TextFileContentState,ImageFileContentState,UnreadableFileTypeContentState,UnreadableTooLargeContentState.unreadablewithreason: 'file_type'.determineFileContentStatenow returnsunreadablewithreason: 'file_type'on decode failures.Written by Cursor Bugbot for commit 254300b. This will update automatically on new commits. Configure here.