Skip to content

Use OIDC for npm publish #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakubno merged 3 commits into from
Oct 29, 2025
Merged

Use OIDC for npm publish #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c6c581
Use OIDC for npm publish
jakubno Oct 27, 2025
0039235
Apply suggestion from @jakubno
jakubno Oct 29, 2025
196e3f2
Update node
jakubno Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions .github/workflows/publish_packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,11 @@ on:
secrets:
E2B_API_KEY:
required: true
NPM_TOKEN:
required: true
PYPI_TOKEN:
required: true

permissions:
id-token: write
contents: write

jobs:
Expand Down Expand Up @@ -46,17 +45,23 @@ jobs:
with:
version: 9.5

- name: Setup Node.js 20
uses: actions/setup-node@v3
- name: Setup Node.js 22
uses: actions/setup-node@v6
with:
node-version: '20.x'
node-version: "22.x"
registry-url: "https://registry.npmjs.org"
cache: pnpm

- name: Configure pnpm
run: |
pnpm config set auto-install-peers true
pnpm config set exclude-links-from-lockfile true

- name: Update npm
run: |
npm install -g npm@^11.6
npm --version

- name: Install dependencies
run: pnpm install --frozen-lockfile

Expand Down Expand Up @@ -84,8 +89,8 @@ jobs:
createGithubReleases: true
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
PYPI_TOKEN: ${{ secrets.PYPI_TOKEN }}
NPM_TOKEN: "" # See https://github.com/changesets/changesets/issues/1152#issuecomment-3190884868

- name: Update lock file
run: pnpm i --no-link --no-frozen-lockfile
Expand Down
11 changes: 6 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
concurrency: ${{ github.workflow }}-${{ github.ref }}

permissions:
id-token: write
contents: write

jobs:
Expand All @@ -27,10 +28,10 @@ jobs:
version: 9.5

- name: Setup Node
uses: actions/setup-node@v3
uses: actions/setup-node@v6
with:
node-version: '20.x'
registry-url: 'https://registry.npmjs.org'
node-version: "22.x"
registry-url: "https://registry.npmjs.org"
Copy link

@cursor cursor bot Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Node.js Version Mismatch in Workflow

The release.yml workflow uses inconsistent Node.js versions. The is_release job was updated to Node 22.x, but the changes job still uses Node 20.x. This version mismatch could lead to compatibility issues or unexpected behavior between jobs.

Fix in Cursor Fix in Web

cache: pnpm
cache-dependency-path: pnpm-lock.yaml

Expand Down Expand Up @@ -67,9 +68,9 @@ jobs:
version: 9.5

- name: Setup Node
uses: actions/setup-node@v3
uses: actions/setup-node@v6
with:
node-version: '20.x'
node-version: '22.x'
registry-url: 'https://registry.npmjs.org'
cache: pnpm
cache-dependency-path: pnpm-lock.yaml
Expand Down