Skip to content

Fix broken permissions in recursive mode #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakubno merged 1 commit into from
Jul 31, 2025
Merged

Fix broken permissions in recursive mode #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions backend_inotify.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,17 @@ func (w *inotify) AddWith(path string, opts ...addOpt) error {
w.sendEvent(Event{Name: root, Op: Create})
}

// If there's a dir for which we don't have read permissions,
// skip it silently. If it's the root directory itself, return an error.
_, infoErr := d.Info()
if infoErr != nil && errors.Is(infoErr, os.ErrPermission) {
if root == path {
return fmt.Errorf("fsnotify: not a readable directory: %q", path)
}

return filepath.SkipDir // Skip this directory silently.
}

wf := flagRecurse
if root == path {
wf |= flagByUser
Expand Down Expand Up @@ -532,6 +543,13 @@ func (w *inotify) handleEvent(inEvent *unix.InotifyEvent, buf *[65536]byte, offs
ev = w.newEvent(curDir, unix.IN_CREATE, 0)
}

// If there's a dir for which we don't have read permissions,
// skip it silently. If it's the root directory itself, return an error.
_, infoErr := d.Info()
if infoErr != nil && errors.Is(infoErr, os.ErrPermission) {
return filepath.SkipDir // Skip this directory silently.
}

if d.IsDir() {
return w.register(curDir, watch.flags, flagRecurse)
}
Expand Down
Loading