Skip to content

fix: gets the alias for paused templates on GetSandboxesSandboxID #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ben-fornefeld merged 4 commits into from
Apr 2, 2026
+8 −0
Merged

fix: gets the alias for paused templates on GetSandboxesSandboxID #2287

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f0e7f7
gets the alias for paused templates on GetSandboxesSandboxID
matthewlouisbrockman Apr 2, 2026
31c6e6c
always set sandbox alias even when ""
matthewlouisbrockman Apr 2, 2026
a41b7be
fix(api): omit empty alias for paused sandbox detail
cursoragent Apr 2, 2026
bf193a9
re-remove the check for not empty
matthewlouisbrockman Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/api/internal/handlers/sandbox_get.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,8 @@ func (a *APIStore) GetSandboxesSandboxID(c *gin.Context, id string) {
networkConfig = lastSnapshot.Snapshot.Config.Network
}

pausedAlias := firstAlias(lastSnapshot.Aliases)

sandbox := api.SandboxDetail{
ClientID: consts.ClientID, // for backwards compatibility we need to return a client id
TemplateID: lastSnapshot.Snapshot.BaseEnvID,
Expand All @@ -218,6 +220,8 @@ func (a *APIStore) GetSandboxesSandboxID(c *gin.Context, id string) {
Lifecycle: sandboxLifecycleToAPI(lastSnapshot.Snapshot.AutoPause, autoResumeConfig),
}

sandbox.Alias = &pausedAlias

if lastSnapshot.Snapshot.Metadata != nil {
metadata := api.SandboxMetadata(lastSnapshot.Snapshot.Metadata)
sandbox.Metadata = &metadata
Expand Down
4 changes: 4 additions & 0 deletions tests/integration/internal/tests/api/sandboxes/sandbox_detail_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ func TestSandboxDetailRunning(t *testing.T) {
returnedSbx := response.JSON200
assert.Equal(t, sbx.SandboxID, returnedSbx.SandboxID)
assert.Equal(t, sbx.TemplateID, returnedSbx.TemplateID)
require.NotNil(t, returnedSbx.Alias)
assert.Equal(t, "base", *returnedSbx.Alias)
}

func TestSandboxDetailReturnsLifecycleAndNetworkConfig(t *testing.T) {
Expand Down Expand Up @@ -100,6 +102,8 @@ func TestSandboxDetailPaused(t *testing.T) {
returnedSbx := response.JSON200
assert.Equal(t, sbx.SandboxID, returnedSbx.SandboxID)
assert.Equal(t, sbx.TemplateID, returnedSbx.TemplateID)
require.NotNil(t, returnedSbx.Alias)
assert.Equal(t, "base", *returnedSbx.Alias)
}

func TestSandboxDetailPausingSandbox(t *testing.T) {
Expand Down
Loading