Skip to content

AWS IaC fixes#2294

Closed
sitole wants to merge 7 commits intomainfrom
aws-iac-fixes
Closed

AWS IaC fixes#2294
sitole wants to merge 7 commits intomainfrom
aws-iac-fixes

Conversation

@sitole
Copy link
Copy Markdown
Member

@sitole sitole commented Apr 2, 2026

  • Added missing support for orchestrator_job_version setup during client start.
  • Reverted part of 874d55b, adding Grafana variables we don't want to maintain for AWS.
  • Setup codeowning for aws iac

sitole added 4 commits April 2, 2026 15:29
Revert changes that setups  grafana logs credentials and adds them to
nomad jobs. This is change we dont want to support in aws setup.
@cursor
Copy link
Copy Markdown

cursor bot commented Apr 2, 2026

PR Summary

Medium Risk
Changes instance bootstrap and Nomad client configuration to depend on fetching version metadata via the Nomad HTTP API, so token/endpoint issues can prevent nodes from joining the cluster. Also removes previously-plumbed Grafana logs credentials, which could break log shipping if any jobs still expect them.

Overview
Updates AWS IaC so Nomad client nodes can optionally fetch latest_orchestrator_job_id from the Nomad Variables API during boot and pass it into run-nomad.sh as node metadata (orchestrator_job_version), with new module inputs to control this and supply the Nomad ACL token. It also removes the previously introduced Grafana logs secret fields and related Terraform wiring for the logs collector, and adds a dedicated CODEOWNERS entry for iac/provider-aws/.

Written by Cursor Bugbot for commit 417a0c5. This will update automatically on new commits. Configure here.

@sitole sitole marked this pull request as ready for review April 2, 2026 13:44
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9ba9f75e3c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the scripts separate?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are fairly different. I want to refactor and unify them in the future. This is just quick fix.

@sitole sitole requested a review from jakubno April 2, 2026 15:03
@sitole sitole closed this Apr 2, 2026
@sitole sitole deleted the aws-iac-fixes branch April 2, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants