Make GCP Redis engine version configurable#2302
Conversation
PR SummaryLow Risk Overview Written by Cursor Bugbot for commit e56f12e. This will update automatically on new commits. Configure here. |
There was a problem hiding this comment.
LGTM — straightforward config change wiring engine version through the Terraform variable chain; the nit about missing validation is noted in the inline comment.
Extended reasoning...
Overview
This PR replaces the hardcoded "VALKEY_8_0" string in iac/provider-gcp/redis/main.tf with a new engine_version variable, propagated all the way from a new GCP_REDIS_ENGINE_VERSION env var through the Makefile tfvar bridge and the provider-level gcp_redis_engine_version variable. Six files are touched, but the changes are purely mechanical plumbing with a safe default (VALKEY_8_0) that preserves existing behavior.
Security Risks
None. This is infrastructure configuration with no auth, crypto, or permission implications. The variable only affects the Memorystore engine version string passed to GCP.
Level of Scrutiny
Low. The change is a textbook "extract hardcoded value into variable" refactor. The wiring is complete and consistent across all layers (env template → Makefile → root variables.tf → module call → redis/variables.tf → resource). The only finding is a nit-level absence of a validation block, which is already surfaced as an inline comment.
Other Factors
No CODEOWNER files appear to govern these Terraform modules based on the repo structure. The inline comment covers the one actionable nit; it does not block correctness or safety of the change.
Make GCP Redis engine version configurable to allow changes between environments.