MaxSize for attachments & UI #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the two introductory pages, “Introduction” & “Get Started” and their controllers/design. Fixed the flow to redirect to the first page when setting up, and from them to the Welcome page.
Added the case in which the user is Logged in but does not have authorizations. Fixed the flow accordingly. Fixed the design of the rest.
…' of https://github.com/KamilaHasanbega/e2email into show-attachments
…/e2email into show-attachments
added 16 commits
August 24, 2016 06:57
Contributor
|
There is no CSS fix in this branch (but it's ok, just rename the PR to mention displaying the size of the attachments in a better way). |
Contributor
Author
chrome/pages/messages/messages.html
Outdated
| <img class="fade-show email-image-content" ng-src="{{mime.content}}" ng-if="mime.type=='image'"> | ||
| <div class="email-text-content col-xs-12" ng-if="mime.type=='text'">{{mime.content}}</div> | ||
| <div class="col-xs-12 single-attachment-received single-attachment" ng-if="mime.url"><span class="file-description"><a blob-href="{{mime.url}}" download="{{mime.filename}}">{{ mime.filename | limitTo: 28 }}{{mime.filename.length > 28 ? '...' : ''}}</a></span><span class="file-size">{{'(' + mime.filesize + ')'}}</span></div> | ||
| <div class="col-xs-12 single-attachment-received single-attachment" ng-if="mime.url"><span class="file-description"><a blob-href="{{mime.url}}" download="{{mime.filename}}">{{ mime.filename | limitTo: 28 }}{{mime.filename.length > 28 ? '...' : ''}}</a></span><span class="file-size" ng-bind="messagesCtrl.convertBytes(mime.filesize)"> {{}} </span></div> |
Contributor
There was a problem hiding this comment.
You don't need {{}}. ng-bind should be enough.
| <div class="row"> | ||
| <div class="col-xs-12 text-center"> | ||
| <button ng-disabled="authorizationCtrl.inProgress" class="btn btn-primary btn-focus" data-ng-click="authorizationCtrl.signIn()">{{'openGmailSettings' | translate}}</button> | ||
| <button ng-disabled="authorizationCtrl.inProgress" class="btn btn-primary btn-focus centreBtn" data-ng-click="authorizationCtrl.signIn()">{{'openGmailSettings' | translate}}</button> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Fixed size of attachments by the library.
-Fixed other CSS