Conversation
…junctions: recreating status quo
-move from_nodes and to_nodes from branch_w_internals directly to pipe and valve as it is differently determined -branch_entries move directly to pipe and valve component -lookup for pipe_pit and pipe idx -correct element check in valve creation -adaptions to enable direct connection between valve and pipe
# Conflicts: # CHANGELOG.rst # src/pandapipes/component_models/abstract_models/branch_wzerolength_models.py # src/pandapipes/test/api/test_special_networks.py
Feature/valve
Delete branch_wzerolength_models.py
…hoff/pandapipes into tutorial_dhnx_pandapipes # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
* Improve readability of setting pipeflow options * Replace logger calls with warnings * Apply _iteration_check only to aux_opts; Exclude unwanted keys; Deepcopy inputs * Remove returning opts from _iteraction_check * Add tests for _iteration_check * Remove usage of map to pursue clarity * Remove check for 'mode' in opts It always exists as long as it exists in default opts, since we're checking the merged dict * Replace warning with logger message for now * Rename 'obj' to 'options' --------- Co-authored-by: SRDM <42580302+SimonRubenDrauz@users.noreply.github.com>
tutorial dhnx to pandapipes updated
* STANET converter: some defaults for KFAKT in net_params * STANET converter: vectorization of valve creation * liniting correction (?) * changelog * stanet converter fix * different naming of valve pipes and pumps if "NAME" entry exists * added valve creation mode in stanet converter and implemented an enum for the three modes: - stanet_like (equivalent to stanet_like_valves=True) - separate_pipe (equivalent to stanet_like_valves=False) - only_valve (new mode without inserting a pipe that represents the stanet valve length) * slight change from logger warning to warnings.warn (Deprecation) * added missing import in stanet2pandapipes.py * small fix in create_valves --------- Co-authored-by: srdm <simon.drauz-mauel@retoflow.de> Co-authored-by: SRDM <42580302+SimonRubenDrauz@users.noreply.github.com>
* generalize reindex functions * added heat consumer to element_junction_tuples * linting correction (?) --------- Co-authored-by: Daniel Lohmeier <31214121+dlohmeier@users.noreply.github.com> Co-authored-by: dlohmeier <daniel.lohmeier@retoflow.de>
* -added heat_consumer doc * -added heat_consumer doc toctree * Apply suggestions from code review rename component to heat consumer Co-authored-by: dad616610 <147147326+dad616610@users.noreply.github.com> * Apply suggestions from code review Spelling corrected Co-authored-by: dad616610 <147147326+dad616610@users.noreply.github.com> * Update heat_consumer_res.csv Spelling corrected --------- Co-authored-by: critzenhoff <carl.ritzenhoff@uni-kassel.de> Co-authored-by: dad616610 <147147326+dad616610@users.noreply.github.com>
* Update create.py Due to a refactor _set_entries was changed in pandapower. * Update create.py forgot an import * add old _set_multiple_entries * Update create.py copied over more missing pandapower dependencies. * Update create.py added even more missing imports. * Update create.py updated a weird import. * Update create.py forgot another np. * added fileio requirements in test runners * added fileio requirements in pyproject.toml * correction * correction * consider API change in basic controller (name field); use pandapipes set_entries for valve_pipe component * move fileio pandapower requirement to top level at pandapipes installation * rename initial_pipeflow in storage controller --------- Co-authored-by: V3 <mike.vogt@iee.fraunhofer.de> Co-authored-by: David Heck <david.heck@iee.fraunhofer.de>
…de stanet converter (#753)
* changes in branch weigthing function for nx graph -> reduce to given table * fix of pipe weigthing input for nx graph
…#749) * implemented exponential form of the temperature loss to ambient for stationary branch equations; some bits of cleanup * small changes in tests, as the results of the new method slightly differ in some cases, and the pipeflow converges faster * correction in pipe model for qext; tried first test, but seems problematic with qext and sections * clean API create_pipe * -bugfix -remove UserWarning * no consideration of qext in pipes; warning if length and qext given at the same time * lots of corrections - remove all qext_w occurences for pipes in create.py - correct warnings and testing for u_w_per_m2k when checking against alpha_w_per_m2k - adaption of some create-tests (especially not to use qext_w for pipes anymore) - small correction in derivative_calculation.py * codacy * whitespace ?? * install pandapower[fileio] for running tests * more fileio requirements * test for pipe t results * workflows and installation according to develop * small change in test pipe * changed pipe component model to remove qext_w * remove trailing whitespace codacy * remove trailing whitespace codacy * remove trailing whitespace codacy * correction of non zero length check with qext --------- Co-authored-by: srdm <simon.drauz-mauel@retoflow.de>
* viscosity and compressibility can now be derived from temperature and pressure if a fluid property states that it accepts both * small correction * increase number of iterations for some tests * more corrections in 2d properties, colebrook-white and some components - usage of 2d properties in more places than before (esp. result extraction, properties toolbox) - implementation of Colebrook-White with scipy newton algorithm instead of own function - zero length components initiate K with 1e-3m instead of 1e3m * Revert "increase number of iterations for some tests" This reverts commit 19282cd. * fixes - missing import in derivative_calculation.py - correct interpretation of newton algorithm in scipy used in colebrook-white lambda calculation depending on input (scalar or vector) - had to increase maximum number of colebrook-white iterations for some tests (hard to compare between scipy and hand-written algorithm) * changelog * tiny fix (no major importance) * dynamize fluid properties * added first derivative of colebrook-white term to colebrook method (second derivative not working properly) * small corrections to viscosity and branch result extraction * remove second derivative for colebrook-white algorithm due to instability issues * include logger again * add missing changelog entry * add tolerance of colebrook-white algorithm to user definable options * changes to pyproject.toml * changes to test workflows * changes to test workflows --------- Co-authored-by: srdm <simon.drauz-mauel@retoflow.de>
Co-authored-by: EPrade <90843651+EPrade@users.noreply.github.com>
) * Implement code changes to enhance functionality and improve performance * Finalized the Jupyter Notebooks * Update and retest district heating example notebooks Retest all district heating example notebooks with latest pandapipes dev version: - Verify compatibility of circular_flow_in_a_district_heating_grid.ipynb - Verify compatibility of time_series_in_a_circular_district_heating_grid.ipynb - Verify compatibility of BadPointPressureLiftController.ipynb Updates: - Increase alpha relaxation parameter from 0.2 to 0.5 in time series simulation as suggested in comments - Update notebook metadata to reflect current execution environment - Ensure all examples run successfully with latest dev version All notebooks have been executed and validated to work correctly with the current development version of pandapipes.
* decimal consideration reading csv * adding BAUJAHR and MATERIAL to pipes * wrong variable name
* correct error check * revert some code parts
* stop python 3.9 support * start python 3.13 support
* bugfix
* allow zero flow in thermal calculation * small corrections in order and default values * remove not required imports
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #778 +/- ##
==========================================
- Coverage 84.31% 82.71% -1.60%
==========================================
Files 91 91
Lines 6930 7331 +401
==========================================
+ Hits 5843 6064 +221
- Misses 1087 1267 +180 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.