PF2pp accleration with create_buses#2118
Conversation
…streckenlast as partial loads
KS-HTK
added
stale
# Conflicts: # pandapower/converter/powerfactory/pp_import_functions.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2118 +/- ##
===========================================
- Coverage 77.58% 77.45% -0.13%
===========================================
Files 278 278
Lines 31143 31206 +63
===========================================
+ Hits 24162 24171 +9
- Misses 6981 7035 +54 ☔ View full report in Codecov by Sentry. |
|
Tests are running through but I guess this is due to the low test coverage of PF2pp converter. we need to discuss before merging |
KS-HTK
left a comment
KS-HTK
left a comment
There was a problem hiding this comment.
Also this PR is missing a changelog entry.
| """ | ||
| Adds additonal atributes from powerfactory such as sernum or for_name | ||
|
|
||
| @param item: powerfactory item |
There was a problem hiding this comment.
it would be appreciated if the docstrings are kept in the google style. I know pandapower already uses multiple different styles, but we would prefer new code only uses one type of docstring style.
"""
<descripton>
[long description]
Attributes:
<arg_name> ([type]): <description>
Optional:
<arg_name> ([type]): <description>
Returns: # or Yields:
<type>: <description>
Raises:
<type>: <description>
Example:
>>> [code]
"""types are generally useful but better typed in the function definition and not only in the docstring. When typing is used the docstring can use the types from python.
| for i in range(num_nodes): | ||
| try: | ||
| pf_bus = item.GetNode(i) | ||
| # wenn elmlodlvp, dann bus von elmlodlv parent |
There was a problem hiding this comment.
comments and variable names should be kept in English only.
| params = ADict() | ||
| if pf_variable_p_loads == 'm:P:bus1' and not item.HasResults(0): | ||
| raise RuntimeError('load %s does not have results and is ignored' % item.loc_name) | ||
| raise RuntimeError('load %s does not have results and is ignored' % item.loc_name) |
There was a problem hiding this comment.
why add whitespaces at end of line?
| split_dict[section] = split_dict.get(section, []).append(load) | ||
|
|
||
| else: | ||
| else:#ö. |
There was a problem hiding this comment.
This change should have been its own pull request. See #2809
7 participants
No description provided.