Skip to content

incorporate pandera into network structure - #2788

Merged
heckstrahler merged 264 commits into
release/v4.0.0from
structure_dict_extension
May 5, 2026
Merged

heckstrahler merged 264 commits into
release/v4.0.0from
structure_dict_extension

Conversation

@heckstrahler

@heckstrahler heckstrahler commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

continue work from #2717

  • incorporate pandera schemata into network structure creation

  • make sure string dtypes are properly set after element creation

  • write tests for validation

  • write tests for result validation?

  • test validation for every create function (not all create functions have tests...)

  • automate docu csv creation (see Feature/generate doc csv #2941)

  • CGMES tags

  • default values

  • decide on how to handle name column

  • trafo creation needs tap variable handling, required seems wrong, tap variables should only exist together

TODO: CHANGELOG!!!

Questions:
switch z_ohm required
sc, 3ph dependancy, trafo, trafo3w

heckstrahler and others added 30 commits October 1, 2025 12:49
* add motor.py

* add motor.py

* adding pa.Check to bus
adding min and max value

* adding import for motor

* adding asymmetric_sgen.py
adding import for asymmetric_sgen.py

* deleting import for asymmetric_sgen
deleting current_source from asymmetric_load
adding import for asymmetric_load
note: asymmetric_sgen was not added in the last commit (spelling mistake)

* adding asymmetric_sgen.py
adding import for asymmetric_sgen

* adding storage.py
adding import for storage

* fix doc for gen (cos_phi in csv)
adding gen.py
adding import for gen

* adding shunt.py
adding import for shunt

* fixed formatting in svc_par.csv (max_angle_degree)
adding svc.py
adding import for svc

* adding res_schema for svc
editing schema names
adding format for res_scv

* editing schema names back

* adding vsc.py
adding import for vsc
adding res_schema for vsc
adding import for res_schema

* adding res_schema for motor
adding import for res_motor
adding res_schema for asymmetric_load
adding import for res_asymmetric_load
adding res_schema for asymmetric_sgen
adding import for res_asymmetric_sgen

* adding res_schema for storage
adding import for res_storage
adding res_schema for gen
adding import for res_gen
adding res_schema for shunt
adding import for res_shunt

* deleting strict_False from res_schema

* adding 3ph for asymmetric_load
adding import for res_schema_3ph
adding 3ph for asymmetric_sgen
adding import for res_schema_3ph
adding 3ph for storage
adding import for res_schema_3ph

* adding metadata to storage
adding metadata to gen
added pandera stubs to requirements
KS-HTK and others added 4 commits April 14, 2026 10:18
* updated the issue templates to use the issue types instead of labels and title
minor changes in forms layouts

* fix for config not parsing by github (hopefully)
added documentation template
added emoji to template title for more visual guidance

* uniform formatting for templates

* added missing blank line at end of file
Only display a logger message if GetActiveScenario is not None
Added else case with a info message if no study case / scenario is active.
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
* updated ltds notebooks

* updated LTDS notebooks for mapping Excel data

* updated LTDS notebooks for mapping Excel data

* UKPN Jupiter Notebook

* fix UKPN Jupiter Notebook

* fix UKPN Jupiter Notebook

* fix UKPN Jupiter Notebook
furqan463 and others added 17 commits April 17, 2026 10:15
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
* fix(cmin): fix cmin for low voltage 10% tolerance
* Fix reindex_buses

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>

* Add allow_duplicate_index argument

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>

* Fix unused import

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>

* Fix test

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>

---------

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
* added/reformatted many docstrings

* added show_plot=False to test_plotting_toolbox

* refactored docstrings and added types

* fixed f-string in groups.py

* fixed incorrect type

* fixed incorrect type

* fixed missing import

* fixed import issue with specific lightsim2grid versions

* fixed mypy issues in contingency
refactored test in test_contingency

* fixed mypy issues

* updated var name
* updated the contributing.rst

* removed raw directive

* changed contributing to markdown for better github compatibility
replaced contributing on readTheDocs by link to GitHub

* Added a section on changelog to the contributing.md
Added a changelog entry to the changelog

* Update CHANGELOG.rst
* colormap-integration in simple_plot

* adjust colors
*add docstrings
*add second button to better visualize options for the user

* change ext_grid color

* some formatting

* only plot colormap if buses or lines are available (fix tutorial-test error)

* removed some spaces
removed some whitelines
added results to hover info

* add changelog entry

* adepted authors

* adapted zorder
make plotting bus-switches optional

* typo

* small adaptions

* small adjustments

---------

Co-authored-by: KS_HTK <2981026+KS-HTK@users.noreply.github.com>
* updated ltds notebooks

* updated LTDS notebooks for mapping Excel data

* updated LTDS notebooks for mapping Excel data

* UKPN Jupiter Notebook

* fix UKPN Jupiter Notebook

* fix UKPN Jupiter Notebook

* fix UKPN Jupiter Notebook

* update LTDS Jupiter Notebook respecting new Excel format

---------

Co-authored-by: David Heck <david.heck@iee.fraunhofer.de>
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
* Fix tutorial on power flow

* Updated Jupyter notebooks for UKPN

* Fix on tutorial directory
* fixed cim converter not setting const_[zi]_[pq]_percent columns

* fixed regression from merge

* disable voltage_depend_loads for lightsim2grid tests
added warning for ls2g & voltage_depend_loads in doc

* revert once voltage_depend_loads has been fixed.
this commit only disables voltage_depend_loads.

---------
Co-authored-by: David Heck <david.heck@iee.fraunhofer.de>
…2990)

* abs tap_step_percent

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>

* Add changelog, test case

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>

* Remove code duplication

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>

---------

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
fixed incorrect docstring type
@heckstrahler
heckstrahler dismissed KS-HTK’s stale review May 5, 2026 10:50

changes resolved

@sonarqubecloud

sonarqubecloud Bot commented May 5, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
7.0% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@heckstrahler
heckstrahler merged commit 3bac272 into release/v4.0.0 May 5, 2026
5 of 19 checks passed
@heckstrahler
heckstrahler deleted the structure_dict_extension branch May 5, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet