Skip to content

Conversation

@furqan463
Copy link
Contributor

In asymmetric_load and asymmetric_sgen create seperate sn_ph_mva attributes while retaining the total nominal power sn_mva so it doesn't break. The need for separate sn_mva is for unbalanced load allocation/ load assignment based on sn_mva.

Signed-off-by: furqan463 <[email protected]>
@furqan463 furqan463 changed the title [Feature] Separate nominal mva for each phase Feature/Separate nominal mva for each phase Dec 21, 2025
@codecov
Copy link

codecov bot commented Dec 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.74%. Comparing base (f965760) to head (f531fa0).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2838   +/-   ##
========================================
  Coverage    71.74%   71.74%           
========================================
  Files          351      351           
  Lines        37150    37150           
========================================
  Hits         26653    26653           
  Misses       10497    10497           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@furqan463
Copy link
Contributor Author

@vogt31337 can you please review this.

@vogt31337
Copy link
Contributor

vogt31337 commented Dec 23, 2025

@furqan463 , I already saw this PR. I will merge IT later, but I am Not Sure If there are Not other Elements which also need to be adapted. And please add a Line to the changelog

Signed-off-by: furqan463 <[email protected]>
@furqan463
Copy link
Contributor Author

@furqan463 , I already saw this PR. I will merge IT later, but I am Not Sure If there are Not other Elements which also need to be adapted. And please add a Line to the changelog

added changelog. please check "Networkstructure.py", there's no other element having separate power attributes for each phase.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2026

@vogt31337 vogt31337 merged commit 808fee4 into e2nIEE:develop Jan 5, 2026
20 of 26 checks passed
@furqan463 furqan463 deleted the update_sn_mva branch January 5, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants