Skip to content

fix cmin for low voltage 10% tolerance#2913

Open
nis-nurr wants to merge 5 commits intoe2nIEE:developfrom
nis-nurr:develop
Open

fix cmin for low voltage 10% tolerance#2913
nis-nurr wants to merge 5 commits intoe2nIEE:developfrom
nis-nurr:develop

Conversation

@nis-nurr
Copy link
Copy Markdown

This pull request updates the handling of c factor in low voltage grids and synchronizes the expected results in several short-circuit calculation tests to match the new logic. The main change is the use of correct minimum c factor (c_min) for lv_tol_percentage 10 instead of a fixed value.

Voltage tolerance calculation improvements:

  • Updated _add_c_to_ppc in pandapower/build_bus.py to use c_min variable for LV bus voltage coefficient, replacing the previous fixed value and ensuring consistency with IEC 60909.

Test coverage enhancements:

  • Added a new minimal test test_iec60909_on_single_branch in pandapower/test/shortcircuit/test_sc_single_bus.py to verify short-circuit calculations on a single branch for both 6% and 10% voltage tolerances, which we also verified manually.

See also the discussion in #2846

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.86%. Comparing base (2efb4f9) to head (c410057).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2913   +/-   ##
========================================
  Coverage    71.86%   71.86%           
========================================
  Files          351      351           
  Lines        37856    37858    +2     
========================================
+ Hits         27206    27208    +2     
  Misses       10650    10650           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vogt31337 vogt31337 requested a review from marcopau March 21, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant