fix cmin for low voltage 10% tolerance#2913
Open
nis-nurr wants to merge 5 commits intoe2nIEE:developfrom
Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2913 +/- ##
========================================
Coverage 71.86% 71.86%
========================================
Files 351 351
Lines 37856 37858 +2
========================================
+ Hits 27206 27208 +2
Misses 10650 10650 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request updates the handling of c factor in low voltage grids and synchronizes the expected results in several short-circuit calculation tests to match the new logic. The main change is the use of correct minimum c factor (
c_min) for lv_tol_percentage 10 instead of a fixed value.Voltage tolerance calculation improvements:
_add_c_to_ppcinpandapower/build_bus.pyto usec_minvariable for LV bus voltage coefficient, replacing the previous fixed value and ensuring consistency with IEC 60909.Test coverage enhancements:
test_iec60909_on_single_branchinpandapower/test/shortcircuit/test_sc_single_bus.pyto verify short-circuit calculations on a single branch for both 6% and 10% voltage tolerances, which we also verified manually.See also the discussion in #2846