feat: add IsPalindrome snippet with unit test and README entry#45
feat: add IsPalindrome snippet with unit test and README entry#45
Conversation
|
Thanks for taking the time to contribute👏 |
| class IsPalindromeTest { | ||
|
|
||
| @Test | ||
| fun testPalindromeWithSimpleWord() { |
There was a problem hiding this comment.
For consistency with the rest of the codebase, please rename test functions using backticks and natural language descriptions (e.g., fun recognizes simple word palindrome()). Here and in functions below.
There was a problem hiding this comment.
Thanks a lot for the feedback! 🙌
I’ll update the test function names to use backticks and natural language descriptions as suggested (e.g., fun recognizes simple word palindrome()), to keep it consistent with the rest of the codebase. Appreciate you pointing that out — will make the changes shortly!
e5LA
left a comment
There was a problem hiding this comment.
Thanks for the update @tarun2684, looks really good!
Just one point - I think by mistake you have also commited entire /bin/ folder. Now, your Pull Request shows 25 changed files.
Description
This PR adds a new Kotlin snippet
IsPalindrome.ktto thecodecollection.snippets.stringspackage.The function checks whether a given string is a palindrome, ignoring punctuation and spacing.
Changes:
src/main/kotlin/codecollection/snippets/strings/IsPalindrome.ktsrc/test/kotlin/codecollection/snippets/strings/IsPalindromeTest.ktREADME.mdwith an entry for the new snippetRelated Issue
Closes #18
Let me know if any further changes are needed!