Issue: avoid log reply for graceful restart

[yamingk]

Please refer to HomeStore PR: eBay/HomeStore#827 for details:

Problem Statement:

Replying logs on a graceful shutdown is unnecessary and will slow down the speed for HomeBlks/HomeStore opening up IO traffic unnecessarily. When HomeBlks/HomeStore is being gracefully shutdown, we want to avoid log replay on the next recovery boot.

Solution:

Add check in solo repl dev on_log_found to avoid replying the log if the lsn is already committed and cp-flushed.
Add assert in HomeBlks (PR in a different repo) that for a graceful shutdown, no log reply should happen.

Testing:

Without the fix, running below command will fail on restart boot (because of a known race that is being fixed, which is not relavant in this PR, the fix for that issue is being worked on) consistently.
With the fix, it could pass, and we can verify there is no log reply happened.

./Debug/src/lib/volume/tests/test_volume_io --gtest_filter=VolumeIOTest.LongRunningRandomIO --num_restarts=4 --num_vols=32 --write_num_io=300 --read_num_io=300 --dev_size_mb=1024000 --run_time=300

I am running longer hours with --num_restarts setting to 200 and --write_num_io=999999 for more aggressive testing.

[yamingk]

I will fix this after HomeStore PR is merged

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.56%. Comparing base (0b40663) to head (261e7b3).
⚠️ Report is 53 commits behind head on main.

Files with missing lines	Patch %	Lines
src/lib/homeblks_impl.hpp	0.00%	1 Missing ⚠️
src/lib/volume_mgr.cpp	0.00%	1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   61.68%   71.56%   +9.87%     
==========================================
  Files          15       21       +6     
  Lines         462     1966    +1504     
  Branches       35      243     +208     
==========================================
+ Hits          285     1407    +1122     
- Misses        158      453     +295     
- Partials       19      106      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.