Skip to content

Conversation

@szmyd
Copy link
Collaborator

@szmyd szmyd commented Nov 11, 2025

Remove usage of folly::Expected and folly::Unit in the API. folly::Future remains.

Remove usage of folly::Expected and folly::Unit in the API. folly::Future remains.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 34.54545% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.23%. Comparing base (0b40663) to head (c4ceff0).
⚠️ Report is 52 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/volume_mgr.cpp 24.00% 18 Missing and 1 partial ⚠️
src/lib/volume/volume.cpp 47.82% 8 Missing and 4 partials ⚠️
src/lib/volume/tests/test_volume_io.cpp 0.00% 3 Missing ⚠️
src/lib/volume/index_fixed_table.hpp 50.00% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #147       +/-   ##
===========================================
+ Coverage   61.68%   72.23%   +10.54%     
===========================================
  Files          15       21        +6     
  Lines         462     1963     +1501     
  Branches       35      243      +208     
===========================================
+ Hits          285     1418     +1133     
- Misses        158      439      +281     
- Partials       19      106       +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@raakella1 raakella1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@szmyd szmyd merged commit 44eb93c into eBay:main Nov 12, 2025
19 checks passed
@szmyd szmyd deleted the cpp23 branch November 12, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants