Issue 44: Create Volume and its recovery#53
Conversation
| mutable std::shared_mutex _volume_lock; | ||
| std::map< volume_id_t, unique< Volume > > _volume_map; | ||
| mutable std::shared_mutex vol_lock_; | ||
| std::map< volume_id_t, VolumePtr > vol_map_; |
There was a problem hiding this comment.
unordered map if we dont want volume list in order.
There was a problem hiding this comment.
Tend to keep using the map for couple of reasons, it (volume map) is inherited from 1.3 and HomeObject is also using map for pg map. Since there will only be tens or less than hundreds of volumes, it think it should be fine and it can provide some ordering access when we introduce the accessibility/visability. We can change it when we see a strong needs.
|
|
||
| public: | ||
| VolumeIndexValue(homestore::bnodeid_t val) { assert(0); } | ||
| VolumeIndexValue(uint32_t val, uint16_t o) : homestore::BtreeIntervalValue(), m_base_val{val}, m_offset{o} {} |
There was a problem hiding this comment.
key is lba and value is pba (BlkId) ?
There was a problem hiding this comment.
I haven't thought through this yet and tend to parking lot when the write part comes in. Please feel free to update this.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 8 14 +6
Lines 172 314 +142
Branches 11 19 +8
======================================
- Misses 172 314 +142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 participants
This PR includes: