Skip to content

Issue 90: wire in discover_svc_id to HomeBlk's Superblk and its recovery#91

Merged
yamingk merged 2 commits intoeBay:mainfrom
yamingk:yk_svc_id
May 13, 2025
Merged

Issue 90: wire in discover_svc_id to HomeBlk's Superblk and its recovery#91
yamingk merged 2 commits intoeBay:mainfrom
yamingk:yk_svc_id

Conversation

@yamingk
Copy link
Collaborator

@yamingk yamingk commented May 13, 2025

Changes:

Wire in discover_svc_id api, on first time boot ,HB will save the svc_id implemented by HB consumer (BM) and persists in its superblock.
on recovery boot, HB will call discover_svc_id with recovered svc_id to BM.

Testing

First time boot
[05/13/25 15:11:41-07:00] [I] [test_volume] [151351] [homeblks_impl.cpp:189:init_homestore] We are starting for the first time on [1587a414-4268-4ad1-ae34-cff4910d923b]. Formatting HomeStore.

Recovery boot
[05/13/25 15:11:54-07:00] [I] [test_volume] [151351] [homeblks_impl.cpp:263:on_hb_meta_blk_found] HomeBlks superblock loaded, boot_cnt: 1, svc_id: 1587a414-4268-4ad1-ae34-cff4910d923b

@yamingk yamingk requested review from raakella1 and szmyd and removed request for szmyd May 13, 2025 22:19
szmyd
szmyd previously approved these changes May 13, 2025
Copy link
Collaborator

@szmyd szmyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.00%. Comparing base (0b40663) to head (e07b8c2).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/homeblks_impl.cpp 75.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   61.68%   65.00%   +3.32%     
==========================================
  Files          15       15              
  Lines         462      523      +61     
  Branches       35       43       +8     
==========================================
+ Hits          285      340      +55     
- Misses        158      162       +4     
- Partials       19       21       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yamingk yamingk merged commit 696849c into eBay:main May 13, 2025
21 checks passed
@yamingk yamingk deleted the yk_svc_id branch May 13, 2025 23:06
@yamingk yamingk linked an issue May 31, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HomeBlks to implement our_uuid() to BM

3 participants