Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 80.11% 80.72% +0.60%
==========================================
Files 17 17
Lines 835 882 +47
Branches 80 85 +5
==========================================
+ Hits 669 712 +43
- Misses 125 126 +1
- Partials 41 44 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add recovery changes for write path. Support non overlapping io ranges in UT. Add to index in the recovery path.
|
|
||
| void HomeBlocksImpl::on_write(int64_t lsn, const sisl::blob& header, const sisl::blob& key, | ||
| const std::vector< homestore::MultiBlkId >& blkids, | ||
| const std::vector< homestore::MultiBlkId >& new_blkids, |
There was a problem hiding this comment.
nit: can we add a detailed API signature in listener.hpp on_commit API, I know there is a detailed API signature from HomeStore side, however HomeBlocks write path we fill in header/key with some meaning, if we can document it from there, it would be great for others to follow this write path.
Add recovery changes for write path. Support non overlapping io ranges in UT. Add to index in the recovery path.