Skip to content

Add recovery changes for write path.#95

Merged
sanebay merged 1 commit intoeBay:mainfrom
sanebay:recovery_test
May 20, 2025
Merged

Add recovery changes for write path.#95
sanebay merged 1 commit intoeBay:mainfrom
sanebay:recovery_test

Conversation

@sanebay
Copy link
Contributor

@sanebay sanebay commented May 19, 2025

Add recovery changes for write path. Support non overlapping io ranges in UT. Add to index in the recovery path.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.44444% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.72%. Comparing base (ca1d0fa) to head (5b859da).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/volume/tests/test_volume_io.cpp 96.00% 0 Missing and 2 partials ⚠️
src/lib/volume_mgr.cpp 90.90% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   80.11%   80.72%   +0.60%     
==========================================
  Files          17       17              
  Lines         835      882      +47     
  Branches       80       85       +5     
==========================================
+ Hits          669      712      +43     
- Misses        125      126       +1     
- Partials       41       44       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

raakella1
raakella1 previously approved these changes May 19, 2025
Copy link
Contributor

@raakella1 raakella1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Add recovery changes for write path. Support non overlapping
io ranges in UT. Add to index in the recovery path.

void HomeBlocksImpl::on_write(int64_t lsn, const sisl::blob& header, const sisl::blob& key,
const std::vector< homestore::MultiBlkId >& blkids,
const std::vector< homestore::MultiBlkId >& new_blkids,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we add a detailed API signature in listener.hpp on_commit API, I know there is a detailed API signature from HomeStore side, however HomeBlocks write path we fill in header/key with some meaning, if we can document it from there, it would be great for others to follow this write path.

@sanebay sanebay merged commit 4628b6a into eBay:main May 20, 2025
19 checks passed
@sanebay sanebay deleted the recovery_test branch May 20, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants