Add API to trigger snapshot creation manually #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besroy
force-pushed
the
trigger_snapshot
branch
from
901f19d to
730a8cf
Compare
Besroy
force-pushed
the
trigger_snapshot
branch
2 times, most recently
from
e8c2e2b to
f145663
Compare
Besroy
force-pushed
the
trigger_snapshot
branch
from
f145663 to
82e0298
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v4 #374 +/- ##
=====================================
Coverage ? 58.67%
=====================================
Files ? 35
Lines ? 4685
Branches ? 583
=====================================
Hits ? 2749
Misses ? 1650
Partials ? 286 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
JacksonYao287
left a comment
JacksonYao287
left a comment
There was a problem hiding this comment.
LGTM , only two minor comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related HS pr: eBay/HomeStore#840