Conversation
🦋 Changeset detectedLatest commit: 4471963 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
This PR introduces three new "tip" components (evo-tourtip, evo-tooltip, and evo-infotip) to the evo-marko package, along with significant improvements to the evo-expander component that these tips depend on. The expander changes include enhanced positioning, trigger management, and collapse behavior handling, which required updates to dependent components like evo-menu and evo-menu-button.
Changes:
- Added three new tip components with comprehensive Storybook documentation
- Refactored
evo-expanderto support more flexible positioning and interaction patterns - Updated
evo-typeaheadandevo-roving-tabindexto work with HTMLElement instead of element factory functions - Updated Marko dependencies to latest versions
Reviewed changes
Copilot reviewed 31 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/evo-marko/src/tags/tags/evo-typeahead/index.marko | Changed nodeList type from factory functions to direct HTMLElement references |
| packages/evo-marko/src/tags/tags/evo-roving-tabindex/index.marko | Changed nodeList type from factory functions to direct HTMLElement references |
| packages/evo-marko/src/tags/tags/evo-expander/index.marko | Major refactor adding arrow positioning, multiple middleware options, and flexible expand/collapse behaviors |
| packages/evo-marko/src/tags/evo-tourtip/* | New tourtip component with examples and Storybook stories |
| packages/evo-marko/src/tags/evo-tooltip/* | New tooltip component with examples and Storybook stories |
| packages/evo-marko/src/tags/evo-infotip/* | New infotip component with examples and Storybook stories |
| packages/evo-marko/src/tags/evo-menu/index.marko | Updated to work with refactored expander and nodeList changes |
| packages/evo-marko/src/tags/evo-menu-button/index.marko | Updated to use trigger prop and placement instead of reverse |
| packages/evo-marko/src/tags/evo-listbox-button/index.marko | Updated to use trigger prop and removed manual expander calls |
| packages/evo-marko/src/tags/evo-toggle-button-group/toggle-button-group.stories.ts | Documentation improvement for pressedChange description |
| packages/evo-marko/package.json | Updated marko dependency to ^6.0.140 |
| package.json | Updated @marko/type-check dependency to ^2.1.19 |
agliga
left a comment
There was a problem hiding this comment.
LGTM overall, we can always iterate.
Description
<evo-tourtip><evo-tooltip><evo-infotip><evo-expander>which led to updates in<evo-menu>and<evo-menu-button>