Skip to content

ci: removed unused commands, cleaned up version and release commands#494

Merged
agliga merged 1 commit intomainfrom
ci
Feb 5, 2026
Merged

ci: removed unused commands, cleaned up version and release commands#494
agliga merged 1 commit intomainfrom
ci

Conversation

@agliga
Copy link
Collaborator

@agliga agliga commented Feb 5, 2026

Several CI/package changes

  • Misc cleanup from trying to get changesets to publish
  • Changed all npm commands to npm ci
  • Added storybook setup for all snapshots that actually run percy snapshots
  • Changed vitest in react to be vitest run (vitest does watch by default)
  • Removed unused commands, like extra build commands
  • Added --if-present to version and release commands
  • Added define to vitest for react (to hopefully fix an issue with pagination failing randomly)

Copilot AI review requested due to automatic review settings February 5, 2026 18:15
@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2026

⚠️ No Changeset found

Latest commit: 3cedee7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up CI and package configuration by standardizing dependency installation, removing unused commands, and improving the release workflow.

Changes:

  • Standardized all npm i commands to npm ci in CI workflows for more reliable builds
  • Added --if-present flags to version and release commands to prevent failures when scripts don't exist
  • Consolidated Storybook setup by moving asset copying into snapshot commands

Reviewed changes

Copilot reviewed 9 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/skin/package.json Removed unused release and version scripts, added Storybook setup to snapshot commands
packages/evo-react/package.json Changed test command from watch mode to run mode
packages/evo-marko/package.json Simplified release script and removed unused version script
packages/ebayui-core/package.json Added mtc to prepublishOnly script
packages/ebayui-core-react/vite.config.mjs Added global window definition to fix test issues
packages/ebayui-core-react/package.json Updated test and release scripts for consistency
package.json Added --if-present flags to version/release scripts, consolidated build workspace flags
.github/workflows/percy.yml Changed to npm ci and removed redundant asset copy step
.github/workflows/ci.yml Changed to npm ci and removed unused npm update step
Files not reviewed (3)
  • packages/ebayui-core-react/smoke-tests/react-16/package-lock.json: Language not supported
  • packages/ebayui-core-react/smoke-tests/react-18/package-lock.json: Language not supported
  • packages/ebayui-core-react/smoke-tests/react-19/package-lock.json: Language not supported

@agliga agliga merged commit a3a1a37 into main Feb 5, 2026
6 checks passed
@agliga agliga deleted the ci branch February 5, 2026 19:45
"start": "NODE_OPTIONS=--openssl-legacy-provider storybook dev -p 9001 -c .storybook --no-open",
"storybook": "NODE_OPTIONS=--openssl-legacy-provider storybook dev -p 9001 -c .storybook --no-open",
"test": "vitest",
"test": "vitest run",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noooo 😢 ! This is because CI=false in local development. It is so cool to have npm test having watch by default

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine but we should do vitest run for build. It hangs in build because of that
Or change the build to do ci=true?

"release": "npm run build",
"start": "storybook dev -p 9001",
"test": "vitest --browser.headless --passWithNoTests",
"test": "vitest run --browser.headless --passWithNoTests",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants