Conversation
|
There was a problem hiding this comment.
Pull request overview
Stabilizes flaky carousel and table loading tests by improving async handling and mocking time/tween behavior, plus updates table loading markup expectations around disabling interactive elements.
Changes:
- Reworked table loading tests to properly await assertions (replacing
forEach(async ...)). - Added Vitest fake timers + mocked scroll transition to reduce carousel test flakiness/timeouts.
- Updated table header sort button markup to apply
tabindex="-1"while loading (and snapshot updates).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/ebayui-core/src/components/ebay-table/test/loading/test.browser.js | Fixes async assertion waiting and updates expectations for disabled buttons/links in loading state. |
| packages/ebayui-core/src/components/ebay-table/test/snapshots/test.server.js.snap | Snapshot updates to reflect loading-state tabindex changes. |
| packages/ebayui-core/src/components/ebay-table/index.marko | Adds tabindex management for sort buttons during loading. |
| packages/ebayui-core/src/components/ebay-carousel/test/test.browser.js | Introduces fake timers and mocks scroll transition implementation to reduce test flakiness. |
forEach. Changed this to do a map and await forPromises.allBonus changes