Skip to content

fix(tokens): updated to the latest design tokens and fixed skeleton#530

Merged
agliga merged 1 commit intomainfrom
tokens
Feb 24, 2026
Merged

fix(tokens): updated to the latest design tokens and fixed skeleton#530
agliga merged 1 commit intomainfrom
tokens

Conversation

@agliga
Copy link
Collaborator

@agliga agliga commented Feb 23, 2026

Description

  • Updated tokens file
  • Updated skeleton references

Checklist

  • I verify all changes are within scope of the linked issue
  • I added/updated/removed testing (Storybook in Skin) coverage as appropriate
  • I tested the UI in all supported browsers
  • I tested the UI in dark mode and RTL mode

Copilot AI review requested due to automatic review settings February 23, 2026 23:41
@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2026

🦋 Changeset detected

Latest commit: 73977f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #439 where skeleton animations were invisible due to missing CSS tokens. The fix updates the @ebay/design-tokens package from v2.0.2 to v2.2.2, which provides the new standardized loading tokens (color-loading-on-primary-state-1/2 and color-loading-on-secondary-state-1/2), and updates the skeleton component to use these new token names instead of the missing legacy names.

Changes:

  • Updated @ebay/design-tokens dependency from v2.0.2 to v2.2.2
  • Updated skeleton animations to use new standardized token names
  • Regenerated all dist CSS files with new tokens across all theme variants

Reviewed changes

Copilot reviewed 3 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/skin/src/sass/skeleton/skeleton.scss Updated keyframe animations to use new token names (color-loading-on-primary-state-1/2 and color-loading-on-secondary-state-1/2)
packages/skin/dist/skeleton/skeleton.css Regenerated dist file with updated token references
packages/skin/dist/tokens/*.css Added new loading state tokens to all theme variants (evo-light, evo-dark, evo-live-light, evo-live-dark, and -class versions)
package.json Bumped @ebay/design-tokens from ^2.0.2 to ^2.2.2
package-lock.json Updated dependency lock with new design-tokens version and peer dependency changes
.changeset/mighty-peas-bathe.md Added changeset documenting the token update and skeleton fix

@agliga agliga self-assigned this Feb 24, 2026
Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@agliga agliga merged commit 7c386a8 into main Feb 24, 2026
14 checks passed
@agliga agliga deleted the tokens branch February 24, 2026 21:59
@github-actions github-actions bot mentioned this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

skeleton: Default and On-Secondary skeleton variants are invisible due to missing tokens

4 participants