Conversation
🦋 Changeset detectedLatest commit: 73977f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #439 where skeleton animations were invisible due to missing CSS tokens. The fix updates the @ebay/design-tokens package from v2.0.2 to v2.2.2, which provides the new standardized loading tokens (color-loading-on-primary-state-1/2 and color-loading-on-secondary-state-1/2), and updates the skeleton component to use these new token names instead of the missing legacy names.
Changes:
- Updated
@ebay/design-tokensdependency from v2.0.2 to v2.2.2 - Updated skeleton animations to use new standardized token names
- Regenerated all dist CSS files with new tokens across all theme variants
Reviewed changes
Copilot reviewed 3 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/skin/src/sass/skeleton/skeleton.scss | Updated keyframe animations to use new token names (color-loading-on-primary-state-1/2 and color-loading-on-secondary-state-1/2) |
| packages/skin/dist/skeleton/skeleton.css | Regenerated dist file with updated token references |
| packages/skin/dist/tokens/*.css | Added new loading state tokens to all theme variants (evo-light, evo-dark, evo-live-light, evo-live-dark, and -class versions) |
| package.json | Bumped @ebay/design-tokens from ^2.0.2 to ^2.2.2 |
| package-lock.json | Updated dependency lock with new design-tokens version and peer dependency changes |
| .changeset/mighty-peas-bathe.md | Added changeset documenting the token update and skeleton fix |
Description
Checklist