Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/skin/dist/svg/icon/icon-arrows-expand-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions packages/skin/dist/svg/icon/icon-arrows-expand-24.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/skin/dist/svg/icon/icon-close-12.svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the X icon is not centered appropriately here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions packages/skin/dist/svg/icon/icon-feedback-error-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions packages/skin/dist/svg/icon/icon-feedback-error-24.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/skin/dist/svg/icon/icon-fingerprint-64.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/skin/dist/svg/icon/icon-spinner-20.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/skin/dist/svg/icon/icon-trend-down-16-fit.svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These trend icons need to be recentered.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/skin/dist/svg/icon/icon-trend-up-16-fit.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
26 changes: 13 additions & 13 deletions packages/skin/dist/svg/icons.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions packages/skin/scripts/generate-images.ts
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,27 @@ class GenerateImages {

const [, , width, height] = sizes.split(" ");

// Validate viewBox matches expected size from filename
// Skip icons that intentionally have non-square aspect ratios:
// - Colored icons (payment methods, etc.)
// - Logo icons (brand marks)
// - PSA icons (brand-specific aspect ratios)
const isColoredIcon = filename.includes("-colored");
const isLogoIcon = filename.includes("-logo");
const isPSAIcon = filename.startsWith("icon-psa");
if (
nameObj.rawSize &&
width !== nameObj.rawSize &&
!isColoredIcon &&
!isLogoIcon &&
!isPSAIcon
) {
console.warn(
`⚠️ ViewBox mismatch in ${filename}: ` +
`expected ${nameObj.rawSize}x${nameObj.rawSize}, got ${width}x${height}`,
);
}

if (isAllowedInDocs) {
this.imageList.push({
name: nameObj.fullName,
Expand Down
4 changes: 2 additions & 2 deletions packages/skin/src/svg/icon/icon-arrows-expand-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions packages/skin/src/svg/icon/icon-arrows-expand-24.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/skin/src/svg/icon/icon-close-12.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions packages/skin/src/svg/icon/icon-feedback-error-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading