Skip to content

v5.x - Remove folly::Expected usage.#138

Merged
szmyd merged 1 commit intoeBay:mainfrom
szmyd:remove_folly_expected
Nov 12, 2025
Merged

v5.x - Remove folly::Expected usage.#138
szmyd merged 1 commit intoeBay:mainfrom
szmyd:remove_folly_expected

Conversation

@szmyd
Copy link
Copy Markdown
Collaborator

@szmyd szmyd commented Nov 12, 2025

No description provided.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 50.94340% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.98%. Comparing base (0262682) to head (237883d).
⚠️ Report is 82 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/factory.cpp 16.66% 6 Missing and 4 partials ⚠️
src/lib/manager_impl.cpp 50.00% 6 Missing and 1 partial ⚠️
src/lib/service.cpp 45.45% 5 Missing and 1 partial ⚠️
src/proto/proto_mesg_factory.cpp 70.00% 1 Missing and 2 partials ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   71.47%   70.98%   -0.49%     
==========================================
  Files          21       20       -1     
  Lines         887      941      +54     
  Branches      103      115      +12     
==========================================
+ Hits          634      668      +34     
- Misses        188      193       +5     
- Partials       65       80      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@szmyd szmyd merged commit d2b97ae into eBay:main Nov 12, 2025
9 checks passed
@szmyd szmyd deleted the remove_folly_expected branch November 12, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants