Closed
Conversation
Major changes in this PR are: 1. Removed the SISL_LOGGING_* macro and use the macro level check with string literal templates instead of dsym check. dsym doesn't work when compiled with multiple libraries. Moreover the requirement to declare and use a module is greatly simplified 2. Make the cache destroy to call the evictor during destruction for each hash node. At present if we have multiple caches on same evictor and if one cache is destroyed, it will leave with evictor having some dead nodes inside.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major changes in this PR are:
Removed the SISL_LOGGING_* macro and use the macro level check with string
literal templates instead of dsym check. dsym doesn't work when compiled with
multiple libraries. Moreover the requirement to declare and use a module is
greatly simplified
Make the cache destroy to call the evictor during destruction for each
hash node. At present if we have multiple caches on same evictor and if one
cache is destroyed, it will leave with evictor having some dead nodes inside.