Fix bugs in Simple Cache by raakella1 · Pull Request #263 · eBay/sisl

raakella1 · 2025-03-30T22:57:51Z

Fix the condition to evict keys in lru_evictor
Remove the key from hashmap after removing from the evictor.
Add a test case to trigger eviction using multiple threads.

codecov-commenter · 2025-03-30T23:08:56Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 76.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 60.79%. Comparing base (370c772) to head (816b94a).
Report is 27 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   64.29%   60.79%   -3.51%     
==========================================
  Files          72       74       +2     
  Lines        4406     4828     +422     
  Branches      555      654      +99     
==========================================
+ Hits         2833     2935     +102     
- Misses       1327     1634     +307     
- Partials      246      259      +13

Components	Coverage Δ
AuthManager	`77.77% <ø> (ø)`
Cache	`37.45% <76.00%> (+7.51%)`	⬆️
FDS	`71.19% <100.00%> (+0.07%)`	⬆️
FileWatcher	`56.25% <ø> (ø)`
Flip	`65.34% <ø> (ø)`
gRPC	`76.04% <64.70%> (-1.01%)`	⬇️
Logging	`15.46% <3.69%> (-14.72%)`	⬇️
Metrics	`80.54% <ø> (+0.33%)`	⬆️
Options	`100.00% <ø> (ø)`
Setting	`56.79% <ø> (ø)`
StatusObject	`73.83% <ø> (ø)`
Utility	`83.47% <100.00%> (+0.75%)`	⬆️
Version	`95.83% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

include/sisl/cache/simple_cache.hpp

…t basis

src/cache/lru_evictor.cpp

include/sisl/cache/simple_hashmap.hpp

include/sisl/cache/evictor.hpp

include/sisl/cache/simple_cache.hpp

raakella1 · 2025-04-18T00:59:25Z

@yamingk I added more comments to the code at several places you suggested

* Fix bugs in Simple Cache * use try_lock to delete the evicted entry from hashmap on a best effort basis * fix bugs in the do_evict logic * add commenst to explain the LRU cache functionality better --------- Co-authored-by: Ravi Nagarjun Akella <raakella1@$HOSTNAME>

raakella1 force-pushed the simple_cache branch from 9bd8090 to 89dd39d Compare April 1, 2025 00:28

raakella1 requested review from shosseinimotlagh, szmyd, xiaoxichen and yamingk April 1, 2025 00:29

raakella1 force-pushed the simple_cache branch from 89dd39d to bc40a3b Compare April 1, 2025 21:46

xiaoxichen reviewed Apr 3, 2025

View reviewed changes

include/sisl/cache/simple_cache.hpp Outdated Show resolved Hide resolved

include/sisl/cache/simple_cache.hpp Outdated Show resolved Hide resolved

include/sisl/cache/simple_cache.hpp Outdated Show resolved Hide resolved

raakella1 force-pushed the simple_cache branch from ab4158f to bc40a3b Compare April 4, 2025 18:04

xiaoxichen approved these changes Apr 5, 2025

View reviewed changes

JacksonYao287 reviewed Apr 6, 2025

View reviewed changes

include/sisl/cache/simple_cache.hpp Outdated Show resolved Hide resolved

include/sisl/cache/simple_cache.hpp Show resolved Hide resolved

JacksonYao287 approved these changes Apr 10, 2025

View reviewed changes

raakella1 force-pushed the simple_cache branch from 9aafa9b to fbf59f5 Compare April 15, 2025 21:49

Ravi Nagarjun Akella added 2 commits April 15, 2025 14:50

Fix bugs in Simple Cache

e37f728

use try_lock to delete the evicted entry from hashmap on a best effor…

5eb1077

…t basis

raakella1 force-pushed the simple_cache branch 3 times, most recently from b3ff5d7 to d3ca31b Compare April 17, 2025 22:22

fix bugs in the do_evict logic

e742646

raakella1 force-pushed the simple_cache branch from d3ca31b to e742646 Compare April 17, 2025 22:33